Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use core background fetch, use .default qos #2071

Merged
merged 4 commits into from
Feb 9, 2024

Commits on Feb 8, 2024

  1. use new backgroundFetch() api

    r10s committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    88f9127 View commit details
    Browse the repository at this point in the history
  2. use qos=.default instead of qos=.background

    .background is probably not what we want - this qos may have long delays,
    apple is a bit opaque in its description,
    but stackoverflow is pretty concrete (https://stackoverflow.com/questions/53141829/performance-of-background-queue-in-swift)
    and we even have a comment in our code ("may be delayed by tens of minutes").
    
    this also fixes the warning
    "Thread running at User-initiated quality-of-service class waiting on a lower QoS thread"
    as before the background was .default while the event handler was .backgound
    
    potentially, this change could explain several issues :)
    r10s committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3b25f20 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    15b1f05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e9ada0 View commit details
    Browse the repository at this point in the history