Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable two-finger pan gesture during chatlist search #2374

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Nov 2, 2024

multi-select is not working in search currently, we even disable it when entering search. so, do not allow entering search using two-finger pan gesture.

we can consider to enable multi-select also during search, but that is another effort i am not sure if it is worth going for (depends on effort and new code needed, of course)

cc @Amzd

…hen entering search. so, do not allow entering search using two-finger pan gesture
@r10s r10s requested a review from Amzd November 2, 2024 11:48
Copy link
Collaborator

@Amzd Amzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@r10s r10s added the bug label Nov 2, 2024
@r10s r10s merged commit 51618b4 into main Nov 2, 2024
1 check passed
@r10s r10s deleted the fix-multi-select-in-search branch November 2, 2024 12:09
@r10s
Copy link
Member Author

r10s commented Nov 2, 2024

will do another PR for the message search, this was even always wrong :)

@r10s r10s changed the title disable two-finger pan gesture during search disable two-finger pan gesture during chatlist search Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants