-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create spec.md #15
Create spec.md #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attestations might change (curious what preston thinks), but otherwise, lgtm
Co-Authored-By: Gregory Markou <[email protected]>
Co-Authored-By: Preston Van Loon <[email protected]>
Co-Authored-By: Preston Van Loon <[email protected]>
Co-Authored-By: Preston Van Loon <[email protected]>
|
||
##### Example | ||
|
||
Below you will find an example `RPC` request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a response? I thought bodies
contains an ssz encoded byte away
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK should be message instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below you will find an example `RPC` request. | |
Below you will find an example `RPC` message. |
|
||
Nodes may request block headers from other nodes using the `GET_BLOCK_HEADERS` message: | ||
|
||
<!--is this necessary?--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary yet
|
||
###### `0x0B` BLOCK_HEADERS | ||
|
||
Nodes may provide block roots to other nodes using the `BLOCK_HEADERS` message, usually in response to a `GET_BLOCK_HEADERS` message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the headers necessary as network objects?
I think GET_BLOCK_BODIES
and BLOCK_BODIES
are sufficient enough. BeaconBlock
contains header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as LES. You sync headers fast, and bodies separately at a slower pace. Having them separated allows a number of other use cases such as light clients.
Co-Authored-By: terence tsao <[email protected]>
@decanus the spec doesn't specify TCP or UDP. I hear through the grapevine that we're using TCP/9000 for now. Should we add this to the spec? Happy to do so myself if I can get commit access to your fork. |
|
||
# Hobbits | ||
|
||
*Written by Dean Eigenmann <[email protected]> & Rene Nayman <[email protected]>* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move acknowledgements to the very end of the doc. Let's make sure Matt Elder gets in there too.
attempts at unfucking the spec