Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spec.md #15

Merged
merged 33 commits into from
Jul 2, 2019
Merged

Create spec.md #15

merged 33 commits into from
Jul 2, 2019

Conversation

decanus
Copy link

@decanus decanus commented Jun 25, 2019

attempts at unfucking the spec

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attestations might change (curious what preston thinks), but otherwise, lgtm

specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Show resolved Hide resolved
specs/spec.md Show resolved Hide resolved
specs/spec.md Show resolved Hide resolved
specs/spec.md Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Outdated Show resolved Hide resolved
specs/spec.md Show resolved Hide resolved

##### Example

Below you will find an example `RPC` request.
Copy link

@terencechain terencechain Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a response? I thought bodies contains an ssz encoded byte away

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK should be message instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below you will find an example `RPC` request.
Below you will find an example `RPC` message.

specs/spec.md Show resolved Hide resolved

Nodes may request block headers from other nodes using the `GET_BLOCK_HEADERS` message:

<!--is this necessary?-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary yet


###### `0x0B` BLOCK_HEADERS

Nodes may provide block roots to other nodes using the `BLOCK_HEADERS` message, usually in response to a `GET_BLOCK_HEADERS` message:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the headers necessary as network objects?
I think GET_BLOCK_BODIES and BLOCK_BODIES are sufficient enough. BeaconBlock contains header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as LES. You sync headers fast, and bodies separately at a slower pace. Having them separated allows a number of other use cases such as light clients.

@benjamincburns
Copy link

@decanus the spec doesn't specify TCP or UDP. I hear through the grapevine that we're using TCP/9000 for now. Should we add this to the spec?

Happy to do so myself if I can get commit access to your fork.


# Hobbits

*Written by Dean Eigenmann <[email protected]> & Rene Nayman <[email protected]>*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move acknowledgements to the very end of the doc. Let's make sure Matt Elder gets in there too.

@atoulme atoulme marked this pull request as ready for review July 2, 2019 17:08
@atoulme atoulme merged commit adfee99 into deltap2p:master Jul 2, 2019
@decanus decanus deleted the patch-25 branch July 3, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.