Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Rebalance + Tests #2

Merged
merged 49 commits into from
Aug 7, 2024
Merged

Simple Rebalance + Tests #2

merged 49 commits into from
Aug 7, 2024

Conversation

mcclurejt
Copy link
Contributor

@mcclurejt mcclurejt commented Jul 30, 2024 •
edited
Loading

Included very simple rebalancing.

Left TODO comments on items for the future.

@mcclurejt mcclurejt marked this pull request as ready for review July 30, 2024 17:59
cashd
cashd reviewed Jul 30, 2024
View reviewed changes
bun.lockb Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/PositionManager.sol Outdated Show resolved Hide resolved
@mcclurejt mcclurejt requested a review from cashd July 31, 2024 19:37
jalextowle
jalextowle reviewed Aug 5, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rebalancing logic looks good to me. I did a pretty comprehensive review, so the next pass should be a lot lighter. One thing to pay attention to are things like import sorting which seem to affect a lot of files.

contracts/interfaces/IEverlongPositions.sol Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/internal/EverlongAdmin.sol Outdated Show resolved Hide resolved
contracts/internal/EverlongAdmin.sol Show resolved Hide resolved
contracts/internal/EverlongAdmin.sol Show resolved Hide resolved
test/units/EverlongPositions.t.sol Outdated Show resolved Hide resolved
test/units/EverlongPositions.t.sol Outdated Show resolved Hide resolved
test/units/EverlongPositions.t.sol Outdated Show resolved Hide resolved
test/units/EverlongPositions.t.sol Outdated Show resolved Hide resolved
test/units/EverlongPositions.t.sol Outdated Show resolved Hide resolved
mcclurejt and others added 8 commits August 5, 2024 11:57
mcclurejt and others added 12 commits August 5, 2024 13:18
@mcclurejt
addressing feedback: %s/revert/failure in tests
6ef834e
@mcclurejt @jalextowle
Update test/units/EverlongPositions.t.sol
97f18fa 
Co-authored-by: Alex Towle <[email protected]>
@mcclurejt @jalextowle
Update test/units/EverlongPositions.t.sol
7a5f676 
Co-authored-by: Alex Towle <[email protected]>
@mcclurejt
addressing feedback: add perf comment
3672143
@mcclurejt
addressing feedback: comment formatting
ff79c6a
@mcclurejt @jalextowle
Update contracts/internal/EverlongPositions.sol
f2e9b65 
Co-authored-by: Alex Towle <[email protected]>
@mcclurejt
addressing feedback: better position encoding and fix exposed test me…
070ac89 
…thods
@mcclurejt
addressing feedback: use notice for exposed internal methods
27a2a2c
@mcclurejt
addressing feedback: comment rewording
1b49166
@mcclurejt
addressing feedback: remove console log
858e5cc
@mcclurejt
addressing feedback: remove console log
34e06ae
@mcclurejt
addressing feedback: import reordering
2af3ba5
jalextowle
jalextowle reviewed Aug 5, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job on this one 😄. You did an excellent job rethinking some of the sins that were committed in Hyperdrive's tests, and I really like the improvements that you made to things like the interface and mixin design. It's a real treat to see the old patterns being refreshed and improved, and I'm looking forward to seeing them come back into the older codebase.

@mcclurejt mcclurejt merged commit d310379 into main Aug 7, 2024
3 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/feat/rebalance+tests branch August 7, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

@cashd cashd Awaiting requested review from cashd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcclurejt @cashd @jalextowle