Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds selector for getRewardsFn #1638

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Adds selector for getRewardsFn #1638

merged 1 commit into from
Nov 8, 2024

Conversation

DannyDelott
Copy link
Contributor

Adds a selector to prevent directly accessing the rewardsFunctions object.

While here I noticed that the YieldSourceId type does not work outside of the appconfig package, so for now the id argument to the getRewardsFn is typed as string. See #1637 for more info.

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 4a2d6c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:38pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:38pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm
testnet-v1 ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm
trading-competition ⬜️ Ignored (Inspect) Nov 8, 2024 5:38pm

@DannyDelott DannyDelott merged commit 045f535 into main Nov 8, 2024
14 checks passed
@DannyDelott DannyDelott deleted the danny-rewards-selector branch November 8, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants