Addressed review feedback from @jrhea

delvtech · Aug 17, 2024 · b9bae53 · b9bae53
1 parent 57c2f70
commit b9bae53
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 4 deletions.
diff --git a/contracts/src/interfaces/IChainlinkAggregatorV3.sol b/contracts/src/interfaces/IChainlinkAggregatorV3.sol
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
-pragma solidity ^0.8.0;
+pragma solidity ^0.8.20;
 
 interface IChainlinkAggregatorV3 {
     function decimals() external view returns (uint8);

diff --git a/contracts/src/libraries/SafeCast.sol b/contracts/src/libraries/SafeCast.sol
@@ -26,8 +26,6 @@ library SafeCast {
         y = uint128(x);
     }
 
-    // FIXME: Add unit tests for this.
-    //
     /// @notice This function safely casts an int256 to an uint256.
     /// @param x The int256 to cast to uint256.
     /// @return y The uint256 casted from x.

diff --git a/contracts/test/MockSafeCast.sol b/contracts/test/MockSafeCast.sol
@@ -12,6 +12,10 @@ contract MockSafeCast {
         y = SafeCast.toUint128(x);
     }
 
+    function toUint256(int256 x) external pure returns (uint256 y) {
+        y = SafeCast.toUint256(x);
+    }
+
     function toInt128(uint256 x) external pure returns (int128 y) {
         y = SafeCast.toInt128(x);
     }

diff --git a/test/instances/chainlink/ChainlinkTest.t.sol b/test/instances/chainlink/ChainlinkTest.t.sol
@@ -640,7 +640,7 @@ contract ChainlinkHyperdriveTest is InstanceTest {
         assertApproxEqAbs(
             baseProceeds,
             _shortAmount.mulDown(_variableRate),
-            1e9
+            1e4
         );
 
         // Ensure that the withdrawal was processed as expected.

diff --git a/test/units/libraries/SafeCast.t.sol b/test/units/libraries/SafeCast.t.sol
@@ -77,6 +77,23 @@ contract SafeCastTest is BaseTest {
         mock.toUint128(2 ** 255);
     }
 
+    function test_toUint256() public {
+        MockSafeCast mock = new MockSafeCast();
+
+        uint256 cast_num = mock.toUint256(0);
+        assertEq(cast_num, uint256(0));
+        cast_num = mock.toUint256(1);
+        assertEq(cast_num, uint256(1));
+        cast_num = mock.toUint256(type(int256).max);
+        assertEq(cast_num, uint256(type(int256).max));
+
+        vm.expectRevert();
+        mock.toUint256(-1);
+
+        vm.expectRevert();
+        mock.toUint256(type(int256).min);
+    }
+
     function test_toInt128_fromUint256_fuzz(uint256 num) public {
         MockSafeCast mock = new MockSafeCast();