Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an Aave integration #1081

Merged
merged 65 commits into from
Jul 15, 2024
Merged

Added an Aave integration #1081

merged 65 commits into from
Jul 15, 2024

Conversation

jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Jul 8, 2024

Resolved Issues

Description

Implemented an AaveHyperdrive instance. Due to the higher-than-usual complexity of this integration, code size became a limitation. To side-step this issue, a fourth target was added to the deployment.

The most interesting part of this integration is that Aave has an internal shares mechanism but doesn't expose very many details about it. For example, Aave doesn't have functions like sharesOf, convertToShares, or convertToBase. It also uses 27 digit fixed point precision when performing conversions from shares to base or from base to shares. This led to the integration looking more similar to the EzETH integration than it does to the StETH integration. The share conversion logic should be reviewed closely.

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.

[[Reviewer Name]]

  • Tokens
    • Do all approve calls use forceApprove?
    • Do all transfer calls use safeTransfer?
    • Do all transferFrom calls use msg.sender as the from address?
      • If not, is the function access restricted to prevent unauthorized
        token spend?
  • Low-level calls (call, delegatecall, staticcall, transfer, send)
    • Is the returned success boolean checked to handle failed calls?
    • If using delegatecall, are there strict access controls on the
      addresses that can be called? It shouldn't be possible to delegatecall
      arbitrary addresses, so the list of possible targets should either be
      immutable or tightly controlled by an admin.
  • Reentrancy
    • Are functions that make external calls or transfer ether marked as nonReentrant?
      • If not, is there documentation that explains why reentrancy is
        not a concern or how it's mitigated?
  • Gas Optimizations
    • Is the logic as simple as possible?
    • Are the storage values that are used repeatedly cached in stack or
      memory variables?
    • If loops are used, are there guards in place to avoid out-of-gas
      issues?
  • Visibility
    • Are all payable functions restricted to avoid stuck ether?
  • Math
    • Is all of the arithmetic checked or guarded by if-statements that will
      catch underflows?
    • If Safe functions are altered, are potential underflows and
      overflows caught so that a failure flag can be thrown?
    • Are all of the rounding directions clearly documented?
  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a few nits, but I am going to go ahead and approve.

jalextowle and others added 12 commits July 14, 2024 14:25
@jalextowle jalextowle added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 76e91c9 Jul 15, 2024
32 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/aave branch July 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants