Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etherfi yield source #1110

Merged
merged 29 commits into from
Jul 26, 2024
Merged

etherfi yield source #1110

merged 29 commits into from
Jul 26, 2024

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented Jul 22, 2024

Description

Etherfi integration implementation. Code for Etherfi can be found here:

https://github.com/etherfi-protocol/smart-contracts/tree/master

@coveralls
Copy link
Collaborator

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10113352953

Details

  • 49 of 72 (68.06%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 90.973%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/deployers/eeth/EETHHyperdriveCoreDeployer.sol 2 3 66.67%
contracts/src/deployers/eeth/EETHTarget0Deployer.sol 1 2 50.0%
contracts/src/deployers/eeth/EETHTarget1Deployer.sol 1 2 50.0%
contracts/src/deployers/eeth/EETHTarget2Deployer.sol 1 2 50.0%
contracts/src/deployers/eeth/EETHTarget3Deployer.sol 1 2 50.0%
contracts/src/deployers/eeth/EETHTarget4Deployer.sol 1 2 50.0%
contracts/src/instances/eeth/EETHTarget0.sol 2 3 66.67%
contracts/src/instances/eeth/EETHConversions.sol 8 10 80.0%
contracts/src/instances/eeth/EETHBase.sol 16 20 80.0%
contracts/src/deployers/eeth/EETHHyperdriveDeployerCoordinator.sol 16 26 61.54%
Totals Coverage Status
Change from base Build 10082126926: -0.7%
Covered Lines: 2197
Relevant Lines: 2415

💛 - Coveralls

@jrhea jrhea changed the title initial implementation of etherfi plus some codegen mods etherfi yield source Jul 23, 2024
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a bunch of nits, but I'm going to approve because I didn't have any comments of substance. Really great work on this dude!

@jrhea
Copy link
Contributor Author

jrhea commented Jul 26, 2024

I had a bunch of nits, but I'm going to approve because I didn't have any comments of substance. Really great work on this dude!

Thanks! Ya the // issue was a search and replace fumble. Thanks for catching that.

@jrhea jrhea enabled auto-merge July 26, 2024 17:07
@jrhea jrhea disabled auto-merge July 26, 2024 17:07
@jrhea jrhea enabled auto-merge July 26, 2024 17:08
@jrhea jrhea added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit ea01c55 Jul 26, 2024
32 checks passed
@jrhea jrhea deleted the etherfi branch July 26, 2024 18:13
@jrhea jrhea mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants