-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades the Solidity version to 0.8.22
#1124
Upgrades the Solidity version to 0.8.22
#1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to remove one more unchecked block here but could totally be missing something.
Otherwise, awesome sauce!
Good callout. I thought about this but ultimately decided against it since it isn't a normal loop counter and I thought the loop looked weird if I added it to the for-loop. |
Pull Request Test Coverage Report for Build 10287158034Details
💛 - Coveralls |
…g' into jalextowle/chore/upgrade-version
46343ea
into
jalextowle/chore/looser-library-and-interface-versioning
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
…contracts (#1123) * Relaxed the version requirements for interfaces, libraries, and test contracts * Addressed review feedback from @mcclurejt * Upgrades the Solidity version to `0.8.22` (#1124) * Updated from Solidity 0.8.20 to 0.8.22 * Removed unchecked blocks for loop counters * Updated the hardhat config
Description
This PR upgrades the Solidity version of contracts that aren't libraries, interfaces, or test utilities to
0.8.22
and removes the unchecked loop counters that are no longer necessary.