Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades the Solidity version to 0.8.22 #1124

Conversation

jalextowle
Copy link
Contributor

Description

This PR upgrades the Solidity version of contracts that aren't libraries, interfaces, or test utilities to 0.8.22 and removes the unchecked loop counters that are no longer necessary.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to remove one more unchecked block here but could totally be missing something.

Otherwise, awesome sauce!

@jalextowle
Copy link
Contributor Author

Might need to remove one more unchecked block at contracts/src/internal/HyperdriveCheckpoint.sol:131 but could totally be missing something.

Otherwise, awesome sauce!

Good callout. I thought about this but ultimately decided against it since it isn't a normal loop counter and I thought the loop looked weird if I added it to the for-loop.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10287158034

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 90.692%

Files with Coverage Reduction New Missed Lines %
contracts/src/libraries/LPMath.sol 1 84.19%
Totals Coverage Status
Change from base Build 10269390706: -0.04%
Covered Lines: 2241
Relevant Lines: 2471

💛 - Coveralls

@jalextowle jalextowle merged commit 46343ea into jalextowle/chore/looser-library-and-interface-versioning Aug 7, 2024
10 checks passed
@jalextowle jalextowle deleted the jalextowle/chore/upgrade-version branch August 7, 2024 15:53
Copy link

github-actions bot commented Aug 7, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: ece72e1 Previous: 7beec95 Deviation Status
addLiquidity: min 33893 gas 33893 gas 0% 🟰
addLiquidity: avg 197331 gas 197158 gas 0.0877% 🚨
addLiquidity: max 474700 gas 474728 gas -0.0059%
checkpoint: min 40316 gas 40316 gas 0% 🟰
checkpoint: avg 144497 gas 144557 gas -0.0415%
checkpoint: max 256108 gas 256108 gas 0% 🟰
closeLong: min 31384 gas 31384 gas 0% 🟰
closeLong: avg 135875 gas 135983 gas -0.0794%
closeLong: max 2539399 gas 2539399 gas 0% 🟰
closeShort: min 31327 gas 31327 gas 0% 🟰
closeShort: avg 131305 gas 131324 gas -0.0145%
closeShort: max 271272 gas 354375 gas -23.4506%
initialize: min 31305 gas 31305 gas 0% 🟰
initialize: avg 352488 gas 352481 gas 0.0020% 🚨
initialize: max 418737 gas 418737 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 174217 gas 174164 gas 0.0304% 🚨
openLong: max 333737 gas 333737 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 174119 gas 174297 gas -0.1021%
openShort: max 414981 gas 414867 gas 0.0275% 🚨
redeemWithdrawalShares: min 31211 gas 31211 gas 0% 🟰
redeemWithdrawalShares: avg 75035 gas 75431 gas -0.5250%
redeemWithdrawalShares: max 305184 gas 305184 gas 0% 🟰
removeLiquidity: min 31217 gas 31217 gas 0% 🟰
removeLiquidity: avg 214893 gas 214205 gas 0.3212% 🚨
removeLiquidity: max 403526 gas 403513 gas 0.0032% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
…contracts (#1123)

* Relaxed the version requirements for interfaces, libraries, and test contracts

* Addressed review feedback from @mcclurejt

* Upgrades the Solidity version to `0.8.22` (#1124)

* Updated from Solidity 0.8.20 to 0.8.22

* Removed unchecked blocks for loop counters

* Updated the hardhat config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants