Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MorphoBlueHyperdrive to ignore all extra data #1125

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Aug 7, 2024

Description

This PR removes any handling of extra data in Morpho.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice contextual comments

@coveralls
Copy link
Collaborator

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10293348421

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.692%

Totals Coverage Status
Change from base Build 10288388658: 0.0%
Covered Lines: 2241
Relevant Lines: 2471

💛 - Coveralls

Copy link

github-actions bot commented Aug 7, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: afe4940 Previous: 9606421 Deviation Status
addLiquidity: min 33893 gas 33893 gas 0% 🟰
addLiquidity: avg 197010 gas 197228 gas -0.1105%
addLiquidity: max 474700 gas 474700 gas 0% 🟰
checkpoint: min 40316 gas 40316 gas 0% 🟰
checkpoint: avg 144590 gas 144542 gas 0.0332% 🚨
checkpoint: max 256108 gas 256108 gas 0% 🟰
closeLong: min 31384 gas 31384 gas 0% 🟰
closeLong: avg 136045 gas 135877 gas 0.1236% 🚨
closeLong: max 2539399 gas 2539399 gas 0% 🟰
closeShort: min 31327 gas 31327 gas 0% 🟰
closeShort: avg 131349 gas 131321 gas 0.0213% 🚨
closeShort: max 401039 gas 308443 gas 30.0205% 🚨
initialize: min 31305 gas 31305 gas 0% 🟰
initialize: avg 352460 gas 352428 gas 0.0091% 🚨
initialize: max 418737 gas 418737 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 174251 gas 174176 gas 0.0431% 🚨
openLong: max 333737 gas 333737 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 174141 gas 174176 gas -0.0201%
openShort: max 415133 gas 414965 gas 0.0405% 🚨
redeemWithdrawalShares: min 31211 gas 31211 gas 0% 🟰
redeemWithdrawalShares: avg 75355 gas 75353 gas 0.0027% 🚨
redeemWithdrawalShares: max 305184 gas 305184 gas 0% 🟰
removeLiquidity: min 31217 gas 31217 gas 0% 🟰
removeLiquidity: avg 214071 gas 215029 gas -0.4455%
removeLiquidity: max 403526 gas 403526 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle changed the title Updated MorphoBlueHyperdrive to include 32 bytes of pass-through data Updated MorphoBlueHyperdrive to ignore all extra data Aug 7, 2024
@jalextowle jalextowle added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit d49927e Aug 8, 2024
32 checks passed
@jalextowle jalextowle deleted the jalextowle/fix/morpho-passthrough-data branch August 8, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants