-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a test suite for the Morpho wstETH/USDC market #1127
Conversation
b78633c
to
4de2e8f
Compare
360d30a
to
457518d
Compare
Pull Request Test Coverage Report for Build 10435093647Details
💛 - Coveralls |
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
test/instances/morpho-blue/MorphoBlue_wstETH_USDC_Hyperdrive.t.sol
Outdated
Show resolved
Hide resolved
test/instances/morpho-blue/MorphoBlue_wstETH_USDC_Hyperdrive.t.sol
Outdated
Show resolved
Hide resolved
test/instances/morpho-blue/MorphoBlue_wstETH_USDC_Hyperdrive.t.sol
Outdated
Show resolved
Hide resolved
test/instances/morpho-blue/MorphoBlue_wstETH_USDC_Hyperdrive.t.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits and q's, nothing major
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! I am going to approve, but I do have a couple of questions and a suggestion to tighten the error bounds on test_round_trip_short_maturity
Description
This PR adds a test suite for the Morpho wstETH/USDC market to ensure that precision issues don't result in problems. This is necessary since USDC only has 6 decimals and Morpho has an abnormally low share price of ~1e12.