morpho blue usde dai deploy

[mcclurejt]

Resolved Issues

Description

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.

[[Reviewer Name]]

• Tokens
  • Do all approve calls use forceApprove?
  • Do all transfer calls use safeTransfer?
  • Do all transferFrom calls use msg.sender as the from address?
    • If not, is the function access restricted to prevent unauthorized
      token spend?
• Low-level calls (call, delegatecall, staticcall, transfer, send)
  • Is the returned success boolean checked to handle failed calls?
  • If using delegatecall, are there strict access controls on the
    addresses that can be called? It shouldn't be possible to delegatecall
    arbitrary addresses, so the list of possible targets should either be
    immutable or tightly controlled by an admin.
• Reentrancy
  • Are functions that make external calls or transfer ether marked as nonReentrant?
    • If not, is there documentation that explains why reentrancy is
      not a concern or how it's mitigated?
• Gas Optimizations
  • Is the logic as simple as possible?
  • Are the storage values that are used repeatedly cached in stack or
    memory variables?
  • If loops are used, are there guards in place to avoid out-of-gas
    issues?
• Visibility
  • Are all payable functions restricted to avoid stuck ether?
• Math
  • Is all of the arithmetic checked or guarded by if-statements that will
    catch underflows?
  • If Safe functions are altered, are potential underflows and
    overflows caught so that a failure flag can be thrown?
  • Are all of the rounding directions clearly documented?
• Testing
  • Are there new or updated unit or integration tests?
  • Do the tests cover the happy paths?
  • Do the tests cover the unhappy paths?
  • Are there an adequate number of fuzz tests to ensure that we are
    covering the full input space?

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: fe9a2e0	Previous: d49927e	Deviation	Status
addLiquidity: min	33893 gas	33893 gas	0%	🟰
addLiquidity: avg	197770 gas	197210 gas	0.2840%	🚨
addLiquidity: max	474700 gas	474700 gas	0%	🟰
checkpoint: min	40316 gas	40316 gas	0%	🟰
checkpoint: avg	144500 gas	144569 gas	-0.0477%	✅
checkpoint: max	256108 gas	256108 gas	0%	🟰
closeLong: min	31384 gas	31384 gas	0%	🟰
closeLong: avg	135985 gas	135881 gas	0.0765%	🚨
closeLong: max	2539399 gas	2539399 gas	0%	🟰
closeShort: min	31327 gas	31327 gas	0%	🟰
closeShort: avg	131365 gas	131196 gas	0.1288%	🚨
closeShort: max	271272 gas	271272 gas	0%	🟰
initialize: min	31305 gas	31305 gas	0%	🟰
initialize: avg	352474 gas	352482 gas	-0.0023%	✅
initialize: max	418737 gas	418737 gas	0%	🟰
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	174220 gas	174204 gas	0.0092%	🚨
openLong: max	333737 gas	333737 gas	0%	🟰
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	174223 gas	174102 gas	0.0695%	🚨
openShort: max	415133 gas	415133 gas	0%	🟰
redeemWithdrawalShares: min	31211 gas	31211 gas	0%	🟰
redeemWithdrawalShares: avg	75046 gas	75273 gas	-0.3016%	✅
redeemWithdrawalShares: max	305184 gas	305184 gas	0%	🟰
removeLiquidity: min	31217 gas	31217 gas	0%	🟰
removeLiquidity: avg	214965 gas	214538 gas	0.1990%	🚨
removeLiquidity: max	403538 gas	403538 gas	0%	🟰

This comment was automatically generated by workflow using github-action-benchmark.