-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented an Admin Controller #1136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd and
sentilesdal
as code owners
August 20, 2024 05:55
Pull Request Test Coverage Report for Build 10495395776Details
💛 - Coveralls |
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
jrhea
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we decide to go this route, it would be good to thoroughly document in the operations playbook how this is used and what existing pools will have to still be manually updated
jrhea
approved these changes
Aug 20, 2024
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplified the admin configuration of Hyperdrive instances. This feature wires up Hyperdrive to look up the admin configuration from an "admin controller." This admin controller must provide the following data:
hyperdriveGovernance
,feeCollector
,sweepCollector
,checkpointRewarder
, anddefaultPausers
. These are all of the fields that can currently be updated by governance on the Hyperdrive factory, and the intention is that the factory will be the admin controller for deployed pools.This feature is fully backward-compatible.
setPauser
andsetGovernance
were updated to be stub functions since the Hyperdrive factory calls these functions during thedeployAndInitialize
routine.IHyperdrive.PoolConfig
wasn't updated to include theadminController
to avoid changing the interface, and all of the interface changes live inside the deployers and the contract constructors. Handling the changes at this level avoids any deployer coordinator interface changes since the deployer coordinators know which factory they are connected to.