Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest Accrual #1137

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Interest Accrual #1137

merged 2 commits into from
Aug 21, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR adds the minimum interest accrual logic needed for the MCP mainnet fork infrastructure.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10483047654

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 90.744%

Totals Coverage Status
Change from base Build 10476738598: 0.004%
Covered Lines: 2245
Relevant Lines: 2474

💛 - Coveralls

Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: 446dc6f Previous: 32925ea Deviation Status
addLiquidity: min 33893 gas 33893 gas 0% 🟰
addLiquidity: avg 196990 gas 197657 gas -0.3375%
addLiquidity: max 474700 gas 474700 gas 0% 🟰
checkpoint: min 40316 gas 40316 gas 0% 🟰
checkpoint: avg 144490 gas 144528 gas -0.0263%
checkpoint: max 256108 gas 256108 gas 0% 🟰
closeLong: min 31384 gas 31384 gas 0% 🟰
closeLong: avg 135904 gas 136043 gas -0.1022%
closeLong: max 2539399 gas 2539399 gas 0% 🟰
closeShort: min 31327 gas 31327 gas 0% 🟰
closeShort: avg 131265 gas 131397 gas -0.1005%
closeShort: max 271272 gas 271272 gas 0% 🟰
initialize: min 31305 gas 31305 gas 0% 🟰
initialize: avg 352420 gas 352454 gas -0.0096%
initialize: max 418737 gas 418737 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 174386 gas 174258 gas 0.0735% 🚨
openLong: max 333737 gas 333737 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 174110 gas 174185 gas -0.0431%
openShort: max 414932 gas 414981 gas -0.0118%
redeemWithdrawalShares: min 31211 gas 31211 gas 0% 🟰
redeemWithdrawalShares: avg 74976 gas 74970 gas 0.0080% 🚨
redeemWithdrawalShares: max 305184 gas 305184 gas 0% 🟰
removeLiquidity: min 31217 gas 31217 gas 0% 🟰
removeLiquidity: avg 214692 gas 215144 gas -0.2101%
removeLiquidity: max 403473 gas 403526 gas -0.0131%

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 4f070b3 Aug 21, 2024
32 checks passed
@jalextowle jalextowle deleted the jalextowle/infra/interest-accrual branch August 21, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants