Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linea EzETH Integration #1141

Merged
merged 15 commits into from
Aug 27, 2024
Merged

Linea EzETH Integration #1141

merged 15 commits into from
Aug 27, 2024

Conversation

jalextowle
Copy link
Contributor

Description

Adds the Renzo Linea integration. This integration is very similar to the Chainlink integration since the vault share price is provided by an oracle. While we could support deposits with base since xRenzoDeposit has a depositETH function, I chose not to support this option since there are deposit fees.

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! just a couple of questions and a nit. also CI is getting an error about LINEA_RPC_URL

Copy link

github-actions bot commented Aug 25, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 0a7a9e2 Previous: a76e266 Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 192700 gas 193082 gas -0.1978%
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147724 gas 147717 gas 0.0047% 🚨
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 130042 gas 130037 gas 0.0038% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124789 gas 124955 gas -0.1328%
closeShort: max 277300 gas 277300 gas 0% 🟰
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355905 gas 355825 gas 0.0225% 🚨
initialize: max 424766 gas 424766 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 174049 gas 173864 gas 0.1064% 🚨
openLong: max 339743 gas 339743 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172690 gas 172791 gas -0.0585%
openShort: max 415003 gas 415220 gas -0.0523%
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74621 gas 74816 gas -0.2606%
redeemWithdrawalShares: max 311190 gas 311190 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 215498 gas 216203 gas -0.3261%
removeLiquidity: max 403671 gas 403683 gas -0.0030%

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! No functional issues, just nits

hardhat.config.linea.ts Show resolved Hide resolved
hardhat.config.linea.ts Show resolved Hide resolved
tasks/deploy/config/linea/factory.ts Show resolved Hide resolved
tasks/deploy/lib/constants.ts Outdated Show resolved Hide resolved
test/utils/InstanceTest.sol Outdated Show resolved Hide resolved
@jalextowle jalextowle force-pushed the jalextowle/integration/linea-ezeth branch from e04b1f8 to 4987b81 Compare August 26, 2024 16:52
@jalextowle jalextowle added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2024
@jalextowle jalextowle force-pushed the jalextowle/integration/linea-ezeth branch from 248ea6e to 0a7a9e2 Compare August 26, 2024 22:05
@mcclurejt mcclurejt added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit c0f48a7 Aug 27, 2024
32 checks passed
@mcclurejt mcclurejt deleted the jalextowle/integration/linea-ezeth branch August 27, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants