Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sxDai Tests #1144

Merged
merged 14 commits into from
Aug 27, 2024
Merged

sxDai Tests #1144

merged 14 commits into from
Aug 27, 2024

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented Aug 27, 2024 •
edited
Loading

Adding tests for sxDai deployment on Gnosis

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10571297910

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.1%) to 92.255%
Files with Coverage Reduction New Missed Lines %
contracts/src/libraries/LPMath.sol 2 84.19%
Totals Coverage Status
Change from base Build 10569538492: 2.1%
Covered Lines: 2311
Relevant Lines: 2505
💛 - Coveralls

jalextowle
jalextowle approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the last few comments are addressed

@jrhea jrhea enabled auto-merge August 27, 2024 16:23
@jrhea jrhea added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 0ebe34a Aug 27, 2024
30 of 32 checks passed
@jrhea jrhea deleted the sxDai_tests branch August 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@mcclurejt mcclurejt Awaiting requested review from mcclurejt mcclurejt is a code owner

@cashd cashd Awaiting requested review from cashd cashd is a code owner

@sentilesdal sentilesdal Awaiting requested review from sentilesdal sentilesdal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhea @coveralls @jalextowle