Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RsETH on Linea #1152

Merged
merged 39 commits into from
Aug 30, 2024
Merged

RsETH on Linea #1152

merged 39 commits into from
Aug 30, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR adds support for Kelp DAO's rsETH yield source on Linea. This was a pretty standard LRT yield source, but there are a few things for reviewers to think about:

  • Is this named appropriately? The vault shares token is actually called wrsETH, but it is redeemable 1:1 with rsETH. rsETH seems like it has more name recognition, but it's worth thinking about. We could also call this WrsETHHyperdrive.
  • What do we think about supporting asBase = true when the fees are zero? We could just rip this logic out if we wanted to.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10623292718

Details

  • 43 of 64 (67.19%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 89.37%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveCoreDeployer.sol 1 2 50.0%
contracts/src/deployers/rseth-linea/RsETHLineaTarget0Deployer.sol 1 2 50.0%
contracts/src/deployers/rseth-linea/RsETHLineaTarget1Deployer.sol 1 2 50.0%
contracts/src/deployers/rseth-linea/RsETHLineaTarget2Deployer.sol 1 2 50.0%
contracts/src/deployers/rseth-linea/RsETHLineaTarget3Deployer.sol 1 2 50.0%
contracts/src/deployers/rseth-linea/RsETHLineaTarget4Deployer.sol 1 2 50.0%
contracts/src/instances/rseth-linea/RsETHLineaBase.sol 13 17 76.47%
contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveDeployerCoordinator.sol 16 27 59.26%
Files with Coverage Reduction New Missed Lines %
contracts/src/libraries/LPMath.sol 1 84.39%
Totals Coverage Status
Change from base Build 10621797190: -0.6%
Covered Lines: 2354
Relevant Lines: 2634

💛 - Coveralls

Copy link

github-actions bot commented Aug 29, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: dee18e6 Previous: bad6abb Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 192939 gas 192576 gas 0.1885% 🚨
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147737 gas 147792 gas -0.0372%
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 129674 gas 129843 gas -0.1302%
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124902 gas 124712 gas 0.1524% 🚨
closeShort: max 277300 gas 277300 gas 0% 🟰
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355842 gas 355912 gas -0.0197%
initialize: max 424766 gas 424766 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173704 gas 173599 gas 0.0605% 🚨
openLong: max 339743 gas 339743 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172241 gas 172120 gas 0.0703% 🚨
openShort: max 414520 gas 394598 gas 5.0487% 🚨
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74402 gas 76276 gas -2.4569%
redeemWithdrawalShares: max 311190 gas 311190 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 216819 gas 216153 gas 0.3081% 🚨
removeLiquidity: max 403683 gas 403671 gas 0.0030% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, comments are all nits

@jalextowle jalextowle added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit bcffe9c Aug 30, 2024
34 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/linea-rseth branch August 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants