-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RsETH on Linea #1152
Merged
Merged
RsETH on Linea #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove-instance-tests
…ance-tests' into jalextowle/integration/linea-rseth
jalextowle
requested review from
jrhea,
mcclurejt,
cashd and
sentilesdal
as code owners
August 29, 2024 22:04
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
…th' into jalextowle/integration/linea-rseth
mcclurejt
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, comments are all nits
contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveCoreDeployer.sol
Outdated
Show resolved
Hide resolved
contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveDeployerCoordinator.sol
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Kelp DAO's rsETH yield source on Linea. This was a pretty standard LRT yield source, but there are a few things for reviewers to think about:
wrsETH
, but it is redeemable 1:1 with rsETH. rsETH seems like it has more name recognition, but it's worth thinking about. We could also call thisWrsETHHyperdrive
.asBase = true
when the fees are zero? We could just rip this logic out if we wanted to.