Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the verifyDeposit and verifyWithdrawal functions #1156

Merged
merged 20 commits into from
Sep 4, 2024
Merged

Refactored the verifyDeposit and verifyWithdrawal functions #1156

merged 20 commits into from
Sep 4, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR refactors the verifyDeposit and verifyWithdrawal functions so that they don't need to be reimplemented for each instance.

@jalextowle jalextowle force-pushed the jalextowle/integration/refactor-verify-deposit-and-withdrawal branch from 0f47c31 to e3e16e4 Compare August 31, 2024 04:02
@jalextowle jalextowle changed the base branch from main to jalextowle/integration/morpho-blue-wsteth-usda August 31, 2024 04:02
jrhea
jrhea approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 31, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 370d39e Previous: 6bb72b2 Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 192972 gas 193338 gas -0.1893% ✅
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147712 gas 147748 gas -0.0244% ✅
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 130095 gas 129844 gas 0.1933% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124911 gas 124552 gas 0.2882% 🚨
closeShort: max 400869 gas 277300 gas 44.5615% 🚨
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355924 gas 355959 gas -0.0098% ✅
initialize: max 424766 gas 424766 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173760 gas 173762 gas -0.0012% ✅
openLong: max 339743 gas 339743 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172518 gas 172408 gas 0.0638% 🚨
openShort: max 415220 gas 415003 gas 0.0523% 🚨
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74957 gas 75003 gas -0.0613% ✅
redeemWithdrawalShares: max 311190 gas 311190 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 216267 gas 216311 gas -0.0203% ✅
removeLiquidity: max 403683 gas 403671 gas 0.0030% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

mcclurejt
mcclurejt approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits

test/instances/eeth/EETHHyperdrive.t.sol Show resolved Hide resolved
test/instances/eeth/EETHHyperdrive.t.sol Show resolved Hide resolved
test/utils/InstanceTest.sol Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10688295216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.37%
Totals Coverage Status
Change from base Build 10687673553: 0.0%
Covered Lines: 2354
Relevant Lines: 2634
💛 - Coveralls

@jalextowle jalextowle force-pushed the jalextowle/integration/refactor-verify-deposit-and-withdrawal branch from cf7f689 to c61c1d5 Compare September 3, 2024 18:49
Base automatically changed from jalextowle/integration/morpho-blue-wsteth-usda to main September 3, 2024 19:23
@jalextowle jalextowle added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 799a60a Sep 4, 2024
33 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/refactor-verify-deposit-and-withdrawal branch September 4, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhea jrhea jrhea approved these changes

@mcclurejt mcclurejt mcclurejt approved these changes

@cashd cashd Awaiting requested review from cashd cashd is a code owner

@sentilesdal sentilesdal Awaiting requested review from sentilesdal sentilesdal is a code owner

@dpaiton dpaiton Awaiting requested review from dpaiton dpaiton is a code owner

@slundqui slundqui Awaiting requested review from slundqui slundqui is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalextowle @coveralls @jrhea @mcclurejt