-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Instances on ERC4626 #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
reviewed
Jul 11, 2023
jalextowle
reviewed
Jul 11, 2023
jalextowle
reviewed
Jul 11, 2023
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 15, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
reviewed
Jul 18, 2023
jalextowle
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on this PR! I'm approving, so once you've addressed my comments and Jonny's comments, feel free to merge.
Co-authored-by: Alex Towle <[email protected]>
Co-authored-by: Alex Towle <[email protected]>
…elvtech/hyperdrive into controlc/erc4626_consolidation
This was referenced Jul 20, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using instance specific code, this PR consolidates all of our code around the ERC4626 instance. We wrap many different yield sources using Yield Daddy to make the compliant with the ERC4626 standard. This reduces any potential error between different implementations such as
DsrHyperdrive
vsStethHyperdrive
, and allows us to more thoroughly test one instance.I've also worked on adding in a single test suite to verify an ERC4626 is compliant with hyperdrive, and will function as expected