Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test and fixing price per share function in ERC4626 Data Provider #460

Merged
merged 15 commits into from
Jul 13, 2023

Conversation

gtowle03
Copy link
Contributor

@gtowle03 gtowle03 commented Jul 13, 2023

Made all changes based on last reviews

fixes: #437

@gtowle03 gtowle03 requested a review from jalextowle July 13, 2023 16:16
@gtowle03 gtowle03 changed the title Gtowle/temp/ppshare fix Adding test and fixing price per share function in ERC4626 Data Provider Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 63e09f5 Previous: 5007450 Deviation Status
addLiquidity: min 785 gas 709 gas 10.7193% 🚨
addLiquidity: avg 43583 gas 45498 gas -4.2090%
addLiquidity: max 70800 gas 77728 gas -8.9131%
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23044 gas 23019 gas 0.1086% 🚨
checkpoint: max 33438 gas 33407 gas 0.0928% 🚨
closeLong: min 852 gas 659 gas 29.2868% 🚨
closeLong: avg 45987 gas 47497 gas -3.1791%
closeLong: max 86074 gas 83240 gas 3.4046% 🚨
closeShort: min 809 gas 616 gas 31.3312% 🚨
closeShort: avg 40931 gas 42330 gas -3.3050%
closeShort: max 87402 gas 84477 gas 3.4625% 🚨
initialize: min 714 gas 532 gas 34.2105% 🚨
initialize: avg 159493 gas 160281 gas -0.4916%
initialize: max 233625 gas 161781 gas 44.4082% 🚨
openLong: min 740 gas 661 gas 11.9516% 🚨
openLong: avg 113272 gas 114770 gas -1.3052%
openLong: max 180018 gas 175911 gas 2.3347% 🚨
openShort: min 782 gas 709 gas 10.2962% 🚨
openShort: avg 151265 gas 159830 gas -5.3588%
openShort: max 219306 gas 218810 gas 0.2267% 🚨
removeLiquidity: min 762 gas 569 gas 33.9192% 🚨
removeLiquidity: avg 57435 gas 62682 gas -8.3708%
removeLiquidity: max 119378 gas 116558 gas 2.4194% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

coveralls commented Jul 13, 2023

Coverage Status

coverage: 96.509% (+0.3%) from 96.18% when pulling 63e09f5 on gtowle/temp/ppshare-fix into 6d713fe on main.

Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the nits are resolved.

@gtowle03 gtowle03 merged commit 460b0ed into main Jul 13, 2023
5 checks passed
@gtowle03 gtowle03 deleted the gtowle/temp/ppshare-fix branch July 13, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC4626DataProvider does not calculate the price per share correctly
4 participants