Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some intermittent issues with the tests #462

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

jalextowle
Copy link
Contributor

The recent merge to main failed with the following error: https://github.com/delvtech/hyperdrive/actions/runs/5548634836/jobs/10131834321. I fixed this intermittent issue and verified that it wouldn't occur again using 100,000 fuzz runs. This uncovered another intermittent issue in test__updateLiquidity__extremeValues__fuzz, which has also been fixed.

@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: e72af36 Previous: 3fa30bf Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 43296 gas 43439 gas -0.3292%
addLiquidity: max 80569 gas 80569 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23044 gas 23044 gas 0% 🟰
checkpoint: max 33438 gas 33438 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 45989 gas 45987 gas 0.0043% 🚨
closeLong: max 86074 gas 86074 gas 0% 🟰
closeShort: min 809 gas 809 gas 0% 🟰
closeShort: avg 41193 gas 41007 gas 0.4536% 🚨
closeShort: max 87306 gas 87306 gas 0% 🟰
initialize: min 714 gas 714 gas 0% 🟰
initialize: avg 159493 gas 159493 gas 0% 🟰
initialize: max 233625 gas 233625 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 113674 gas 113053 gas 0.5493% 🚨
openLong: max 180018 gas 180018 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 150680 gas 151363 gas -0.4512%
openShort: max 219306 gas 219306 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 57593 gas 57156 gas 0.7646% 🚨
removeLiquidity: max 119378 gas 119378 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 96.571% (+0.06%) from 96.509% when pulling e72af36 on jalextowle/fix/intermittent-failure into 3fa30bf on main.

@jalextowle jalextowle merged commit bfc1230 into main Jul 15, 2023
@jalextowle jalextowle deleted the jalextowle/fix/intermittent-failure branch July 15, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants