fix: Locked down the sweep function
#473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
|
Codesize issues are becoming very annoying, can't wait to fix it |
ControlCplusControlV
suggested changes
Jul 20, 2023
ControlCplusControlV
approved these changes
Jul 20, 2023
jrhea
approved these changes
Jul 20, 2023
gtowle03
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Locked down the `sweep` function * Added a check on `isSweepable` in `test_erc4626_sweep` * Appeased the linter * Turned optimizer down to avoid code size issues * Addressed review feedback from @jrhea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #507.
Along with fixing the Spearbit issue, this PR addresses a medium Certora issue by locking down the targets of
sweepinERC4626Hyperdrive. Previously, thesweepfunction could be called on any target that is not equal tobaseTokenorpool. Some tokens are accessible through more than one address, which means that it was theoretically possible for all of the Hyperdrive funds to be swept into governance if such a token was used as the base or pool token. To solve this problem, this PR adds a mapping calledisSweepablethat keeps track of which addresses can be swept. This list can't be updated after initialization, so users can verify that the pool is safe from being swept.