Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the lpSharePrice to getPoolInfo #535

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jalextowle
Copy link
Contributor

Adds the lpSharePrice to getPoolInfo in anticipation of cutting v0.0.11.

@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: 966be7b Previous: 2324420 Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 43835 gas 43431 gas 0.9302% 🚨
addLiquidity: max 80528 gas 80528 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 22776 gas 22776 gas 0% 🟰
checkpoint: max 32767 gas 32767 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 45541 gas 45658 gas -0.2563%
closeLong: max 85364 gas 85364 gas 0% 🟰
closeShort: min 809 gas 809 gas 0% 🟰
closeShort: avg 40701 gas 40753 gas -0.1276%
closeShort: max 86800 gas 86896 gas -0.1105%
initialize: min 714 gas 714 gas 0% 🟰
initialize: avg 159389 gas 159389 gas 0% 🟰
initialize: max 233486 gas 233486 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 111803 gas 112219 gas -0.3707%
openLong: max 179317 gas 179317 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 152579 gas 151988 gas 0.3888% 🚨
openShort: max 218825 gas 218825 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 57230 gas 57230 gas 0% 🟰
removeLiquidity: max 118973 gas 118973 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.254% (+2.5%) from 95.745% when pulling 966be7b on jalextowle/data/lp-share-price into 2324420 on main.

@ControlCplusControlV
Copy link
Contributor

It looks like we lose coverage on some files, could you investigate this

Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the OpenLongWithUnderlying() test fails with this error BaseBufferExceedsShareReserves()

@jalextowle jalextowle merged commit 4827596 into main Jul 27, 2023
5 checks passed
@jalextowle jalextowle deleted the jalextowle/data/lp-share-price branch July 27, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants