fix: Short Sandwich #537
Merged
fix: Short Sandwich #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
changed the title
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
jalextowle
force-pushed
the
jalextowle/bug/short-sandwich
branch
from
6110827
to
e4334e4
Compare
jrhea
reviewed
Sep 5, 2023
- For `test__calculateMaxLong__matureShort`, I ultimately settled for a relatively large bound. There are a few strategies that can be used to increase it's performance. First, we should see if adding a stricter constraint on the spot price improves the worst-case performance of `calculateMaxLong`. Second, we can try some of the tricks outlined in this thread: https://math.stackexchange.com/questions/508199/newtons-method-why-is-there-slow-convergence-with-a-high-multiplicity. - For `test_long_multiblock_round_trip_end_of_checkpoint`, the failure occurs rarely, so we can merge without fixing it in this PR. This issue is tracked here: #582. I'll address this issue in an immediate follow-up PR.
jalextowle
force-pushed
the
jalextowle/bug/short-sandwich
branch
from
de26ef7
to
02f3874
Compare
jalextowle
force-pushed
the
jalextowle/bug/short-sandwich
branch
from
d92328e
to
9c2dc75
Compare
jrhea
reviewed
Sep 23, 2023
jrhea
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
This is really good. Just a few comments. On the testing side, i think it would be good to add a path independence test that shows that you can close trades in a different order and still get the same result. i actually tested a few cases when i reviewed this the first time around.
Also, here is a desmos that shows the short sandwhich problem:
https://www.desmos.com/calculator/trao96oozf
and here is the zeta adjustment:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #426.
Aside from implementing the zeta adjustment, this PR also includes significant improvements to both
get_max_longandget_max_short.