Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove python hyperdrive #560

Merged
merged 23 commits into from
Aug 21, 2023
Merged

remove python hyperdrive #560

merged 23 commits into from
Aug 21, 2023

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Aug 17, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 17, 2023 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 809d9a5 Previous: 1aa45ea Deviation Status
addLiquidity: min 785 gas 785 gas 0% 🟰
addLiquidity: avg 44061 gas 43919 gas 0.3233% 🚨
addLiquidity: max 80540 gas 80584 gas -0.0546% ✅
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 29519 gas 29519 gas 0% 🟰
checkpoint: max 85281 gas 85281 gas 0% 🟰
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 21775 gas 21805 gas -0.1376% ✅
closeLong: max 87902 gas 87902 gas 0% 🟰
closeShort: min 765 gas 765 gas 0% 🟰
closeShort: avg 22698 gas 22726 gas -0.1232% ✅
closeShort: max 89140 gas 89140 gas 0% 🟰
initialize: min 803 gas 803 gas 0% 🟰
initialize: avg 159799 gas 159799 gas 0% 🟰
initialize: max 233607 gas 233607 gas 0% 🟰
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 40509 gas 40488 gas 0.0519% 🚨
openLong: max 203109 gas 203109 gas 0% 🟰
openShort: min 782 gas 782 gas 0% 🟰
openShort: avg 52531 gas 52504 gas 0.0514% 🚨
openShort: max 241753 gas 241753 gas 0% 🟰
removeLiquidity: min 762 gas 762 gas 0% 🟰
removeLiquidity: avg 59902 gas 59986 gas -0.1400% ✅
removeLiquidity: max 122813 gas 122813 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 2 times, most recently from 3ac1abe to 60c8064 Compare August 17, 2023 20:19
@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2023 •
edited
Loading

Coverage Status

coverage: 96.168%. remained the same when pulling fd6c7c4 on dpaiton/package-hyperdrive-py into 1aa45ea on main.

@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 2 times, most recently from 74242b8 to 71813b6 Compare August 17, 2023 20:43
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 71813b6 to 7a9b682 Compare August 17, 2023 20:55
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from bf8144f to 22f6933 Compare August 18, 2023 03:22
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 2 times, most recently from 980e961 to c1501a6 Compare August 18, 2023 03:52
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 3 times, most recently from b282d16 to b22d388 Compare August 18, 2023 04:42
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 5 times, most recently from 8fc98de to cd60a66 Compare August 18, 2023 05:14
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 2 times, most recently from 2881c8e to b6db330 Compare August 18, 2023 21:35
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from b6db330 to 188d812 Compare August 18, 2023 21:37
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 028ea64 to 53d3263 Compare August 18, 2023 22:26
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 53d3263 to a0f1e1a Compare August 18, 2023 22:30
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 3 times, most recently from cc132dc to 45f60c9 Compare August 19, 2023 19:55
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 45f60c9 to f92d410 Compare August 19, 2023 19:57
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from b5e1962 to 12b19b0 Compare August 20, 2023 11:35
@dpaiton dpaiton marked this pull request as draft August 20, 2023 11:37
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch 3 times, most recently from 827d86b to e0edd02 Compare August 21, 2023 17:34
@dpaiton dpaiton changed the title package hyperdrive python remove python hyperdrive Aug 21, 2023
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 1288a4d to 809d9a5 Compare August 21, 2023 19:51
@dpaiton dpaiton force-pushed the dpaiton/package-hyperdrive-py branch from 809d9a5 to fd6c7c4 Compare August 21, 2023 19:52
@dpaiton dpaiton marked this pull request as ready for review August 21, 2023 19:52
sentilesdal
sentilesdal approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dpaiton dpaiton merged commit ed731ed into main Aug 21, 2023
8 checks passed
@dpaiton dpaiton deleted the dpaiton/package-hyperdrive-py branch August 21, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentilesdal sentilesdal sentilesdal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpaiton @coveralls @sentilesdal