Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified the present value calculation #566

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Simplified the present value calculation #566

merged 4 commits into from
Aug 22, 2023

Conversation

jalextowle
Copy link
Contributor

Fixes: #563.

@jalextowle jalextowle marked this pull request as ready for review August 22, 2023 08:30
@jalextowle jalextowle requested a review from jrhea August 22, 2023 08:30
@jalextowle jalextowle force-pushed the jalextowle/fixes/present-value-simplification branch from 10c60db to 0398584 Compare August 22, 2023 08:33
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: e23891c Previous: ed731ed Deviation Status
addLiquidity: min 763 gas 785 gas -2.8025% ✅
addLiquidity: avg 45366 gas 43919 gas 3.2947% 🚨
addLiquidity: max 80701 gas 80584 gas 0.1452% 🚨
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 29513 gas 29518 gas -0.0169% ✅
checkpoint: max 83076 gas 85281 gas -2.5856% ✅
closeLong: min 852 gas 852 gas 0% 🟰
closeLong: avg 21564 gas 21802 gas -1.0916% ✅
closeLong: max 87500 gas 87902 gas -0.4573% ✅
closeShort: min 854 gas 765 gas 11.6340% 🚨
closeShort: avg 22539 gas 22726 gas -0.8228% ✅
closeShort: max 87854 gas 89236 gas -1.5487% ✅
initialize: min 803 gas 803 gas 0% 🟰
initialize: avg 159701 gas 159799 gas -0.0613% ✅
initialize: max 233501 gas 233607 gas -0.0454% ✅
openLong: min 740 gas 740 gas 0% 🟰
openLong: avg 41050 gas 40474 gas 1.4231% 🚨
openLong: max 224074 gas 203109 gas 10.3220% 🚨
openShort: min 760 gas 782 gas -2.8133% ✅
openShort: avg 48026 gas 52504 gas -8.5289% ✅
openShort: max 217970 gas 241753 gas -9.8377% ✅
removeLiquidity: min 740 gas 762 gas -2.8871% ✅
removeLiquidity: avg 62455 gas 59902 gas 4.2620% 🚨
removeLiquidity: max 122749 gas 122813 gas -0.0521% ✅

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle enabled auto-merge (squash) August 22, 2023 09:21
@jalextowle jalextowle force-pushed the jalextowle/fixes/present-value-simplification branch from bb32ddf to 16e1f6a Compare August 22, 2023 09:28
@jalextowle jalextowle force-pushed the jalextowle/fixes/present-value-simplification branch from 16e1f6a to 8f1bbc1 Compare August 22, 2023 09:30
jrhea
jrhea approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jalextowle jalextowle merged commit 3e04db3 into main Aug 22, 2023
6 checks passed
@jalextowle jalextowle deleted the jalextowle/fixes/present-value-simplification branch August 22, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhea jrhea jrhea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify the stuck positions component of the present value calculation
2 participants
@jalextowle @jrhea