Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO password spray playbook #36548

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

karinafishman
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11356

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
Packs/Core/Playbooks/playbook-SSO_Password_Spray.yml Outdated Show resolved Hide resolved
@umishkin umishkin self-requested a review September 30, 2024 20:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this change is related to the SSO password spray playbook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw this small mistake in Arik's trigger file and told him that I will fix in my PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this playbook more visually compact, it has less than 20 tasks but visually looks very long

task:
id: 7da596f4-aa21-49e1-8640-366e9803b7cf
version: -1
name: Is the user agent suspicious or user risk score high?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear from the task name if and how you consider the interval analysis, please clarify

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same format as Arik's and Omri's format in the Suspicious SaaS Access From a TOR Exit Node & A successful SSO sign-in from TOR Playbooks
(new line after Early Containment etc..)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will make it more compact together @AdiPeret @karinafishman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants