Seq.sequenceResultM returns seq

demystifyfp · Dec 1, 2021 · 425a337 · 425a337
1 parent 8bdc9b7
commit 425a337
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/FsToolkit.ErrorHandling/Seq.fs b/src/FsToolkit.ErrorHandling/Seq.fs
@@ -3,13 +3,13 @@ namespace FsToolkit.ErrorHandling
 [<RequireQualifiedAccess>]
 module Seq =
 
-    let sequenceResultM (xs: seq<Result<'t, 'e>>) : Result<'t list, 'e> =
+    let sequenceResultM (xs: seq<Result<'t, 'e>>) : Result<'t seq, 'e> =
         let rec loop xs ts =
             match Seq.tryHead xs with
             | Some x ->
                 x
                 |> Result.bind (fun t -> loop (Seq.tail xs) (t :: ts))
-            | None -> Ok(List.rev ts)
+            | None -> Ok(List.rev ts |> List.toSeq)
 
         // Seq.cache prevents double evaluation in Seq.tail
         loop (Seq.cache xs) []
diff --git a/tests/FsToolkit.ErrorHandling.Tests/Seq.fs b/tests/FsToolkit.ErrorHandling.Tests/Seq.fs
@@ -24,6 +24,7 @@ let sequenceResultMTests =
 
               let actual =
                   Seq.sequenceResultM (Seq.map Tweet.TryCreate tweets)
+                  |> Result.map Seq.toList
 
               Expect.equal actual expected "Should have an empty list of valid tweets"
 
@@ -34,6 +35,7 @@ let sequenceResultMTests =
 
               let actual =
                   Seq.sequenceResultM (Seq.map Tweet.TryCreate tweets)
+                  |> Result.map Seq.toList
 
               Expect.equal actual expected "Should have a list of valid tweets"