New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.traverseValidationA' should be private? #168

Closed

AlbertoDePena opened this issue Mar 27, 2022 · 1 comment

Contributor

AlbertoDePena commented Mar 27, 2022

Should List.traverseValidationA' be private just like the other functions that denote recursiveness (rec keyword)?

FsToolkit.ErrorHandling/src/FsToolkit.ErrorHandling/List.fs

Line 79 in a4a0d2d

let rec traverseValidationA' state f xs =

Collaborator

TheAngryByrd commented Apr 4, 2022

Yeah I could see this being private as I doubt you'd want to choose anything other than traverseValidationA and sequenceValidationA.

TheAngryByrd added a commit that referenced this issue


          Fixes #168

ce4ee1d

TheAngryByrd mentioned this issue

178 fix traverse result a #185

Merged

6 tasks

TheAngryByrd closed this as completed in

7c71bb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment