Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Core version warning (net7.0) #194

Closed
quentez opened this issue Nov 9, 2022 · 14 comments
Closed

FSharp.Core version warning (net7.0) #194

quentez opened this issue Nov 9, 2022 · 14 comments
Labels
bug Something isn't working upstream Issue is in an upstream dependency but still affects us

Comments

@quentez
Copy link

quentez commented Nov 9, 2022

Describe the bug
Following what I suspect to be this change, I now get the following warning after upgrading to version 3.3.0:

[NU1608] Detected package version outside of dependency constraint: FsToolkit.ErrorHandling 3.3.0 requires FSharp.Core (= 4.7.2) but version FSharp.Core 7.0.0 was resolved.

To Reproduce
Steps to reproduce the behavior:

  1. Add FsToolkit.ErrorHandling.TaskResult version 3.3.0 to a net7.0 project.
  2. Build the project.

Expected behavior
No warning.

Desktop:

  • OS: macOS 13.0
@Dzoukr
Copy link

Dzoukr commented Nov 9, 2022

Yup, I think there should be >= instead of =

image

@cmeeren
Copy link
Contributor

cmeeren commented Nov 9, 2022

Yes, this was >= before, but is now =. For us who have enabled warnings as errors, this precludes updating FsToolkit.ErrorHandling.

@TheAngryByrd
Copy link
Collaborator

Ah paket has changed rules around its version. Lemme see if I can clean it up

@TheAngryByrd
Copy link
Collaborator

Opened an issue on paket as it seems they are generating a nuspec file differently fsprojects/Paket#4183

@TheAngryByrd
Copy link
Collaborator

I think i'm gonna pull the version from nuget for the moment

@yreynhout
Copy link

This happens for net6.0 projects too.

@abelbraaksma
Copy link

abelbraaksma commented Nov 9, 2022

Fwiw, 3.2.0 does not exhibit this problem, it has the versions as >=. And if I saw it correctly, 3.3 is beta, or did you pull the definitive version already @TheAngryByrd?

@TheAngryByrd
Copy link
Collaborator

I already pulled the official version. Please refer the paket issue I filled as that's the root cause.

@TheAngryByrd TheAngryByrd added bug Something isn't working upstream Issue is in an upstream dependency but still affects us labels Nov 9, 2022
@cmeeren
Copy link
Contributor

cmeeren commented Nov 9, 2022

Do you mean that a new package with unlocked FSharp.Core version won't be published before upstream fixes it? Since the NuGet package is now locked to a fairly old F# version, it may prevent many people from updating until it's fixed. Would be great to have a package released with unlocked version as a quick fix!

@TheAngryByrd
Copy link
Collaborator

Do you mean that a new package with unlocked FSharp.Core version won't be published before upstream fixes it?

Yes, I'm not gonna get into the habit of hand editing nuget packages everytime I need to do deploy and this helps the ecosystem.

TheAngryByrd added a commit that referenced this issue Nov 18, 2022
- [FSharp.Core version warning](#194)
TheAngryByrd added a commit that referenced this issue Nov 18, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
@TheAngryByrd
Copy link
Collaborator

TheAngryByrd added a commit that referenced this issue Nov 18, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
@quentez
Copy link
Author

quentez commented Nov 19, 2022

Looking good on my end!

@cmeeren
Copy link
Contributor

cmeeren commented Nov 19, 2022

Looks good on NuGet! (Assuming that you want to require FSharp.Core 7.0.0 on netstandard2.1.)

image

TheAngryByrd added a commit that referenced this issue Nov 19, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
- [Fixing Fable Build](#196) Credits @alfonsogarciacaro
TheAngryByrd added a commit that referenced this issue Nov 19, 2022
- [FSharp.Core version warning](#194). Credits @TheAngryByrd
- [List.traverseValidationA and List.sequenceValidationA now preserve the order of errors](#192). Credits @ursenzler
- [Fixing Fable Build](#196) Credits @alfonsogarciacaro
@abelbraaksma
Copy link

abelbraaksma commented Nov 25, 2022

Question: do we really need to force upgrade to F# Core 7.0? On NetStandard 2.1, the lowest denominator with tasks) should probably be used, which is 6.0.2, or 6.0.6 (Result additions).

/cc @TheAngryByrd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue is in an upstream dependency but still affects us
Projects
None yet
Development

No branches or pull requests

6 participants