Complete Traverse performance optimisations #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full # Conflicts: # src/FsToolkit.ErrorHandling/List.fs
This was referenced Feb 26, 2021
TheAngryByrd
added a commit
that referenced
this pull request
Feb 26, 2021
- Performance enhancements for traverseValidationA. Credits [@isaacabraham](https://github.com/isaacabraham) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - (#110) (#111) (#113)
TheAngryByrd
added a commit
that referenced
this pull request
Feb 26, 2021
- Performance enhancements for traverseValidationA. Credits [@isaacabraham](https://github.com/isaacabraham) Credits [@TheAngryByrd](https://github.com/TheAngryByrd) - (#110) (#111) (#113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've applied the same optimisation (a @ [ b ] --> b :: a) to the remaining four instances in the List module. We don't use Hopac, and I'm leaving that part alone.
I've also refactored my earlier change to use map rather than explicitly unwrapping ok / error in the match clause (readability).