-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaultError and zipError #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mind adding these to AsyncResult, TaskResult, and JobResult as well?
Sure, haven't use them though, will do later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added to AsyncResult/JobResult/TaskResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the zipError
tests are missing for AsyncResult
/TaskResult
/JobResult
. Mind adding those too?
Did not find tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
- Adds defaultError and zipError helpers Credits [@sep2](https://github.com/sep2) - (#130)
- Adds defaultError and zipError helpers Credits [@sep2](https://github.com/sep2) - (#130)
No description provided.