Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultError and zipError #130

Merged
merged 5 commits into from
May 23, 2021
Merged

Add defaultError and zipError #130

merged 5 commits into from
May 23, 2021

Conversation

sep2
Copy link
Contributor

@sep2 sep2 commented May 20, 2021

No description provided.

TheAngryByrd
TheAngryByrd requested changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind adding these to AsyncResult, TaskResult, and JobResult as well?

@sep2
Copy link
Contributor Author

sep2 commented May 21, 2021

Sure, haven't use them though, will do later

sep2
sep2 commented May 21, 2021
View reviewed changes
Copy link
Contributor Author

@sep2 sep2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to AsyncResult/JobResult/TaskResult

@sep2 sep2 requested a review from TheAngryByrd May 21, 2021 15:06
TheAngryByrd
TheAngryByrd requested changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the zipError tests are missing for AsyncResult/TaskResult/JobResult. Mind adding those too?

@sep2
Copy link
Contributor Author

sep2 commented May 22, 2021

Did not find tests for AsyncResult/TaskResult/JobResult version zip as reference implementations for zipError, mind if I add them as well?

@sep2 sep2 requested a review from TheAngryByrd May 22, 2021 06:25
TheAngryByrd
TheAngryByrd approved these changes May 23, 2021
View reviewed changes
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@TheAngryByrd TheAngryByrd merged commit 935257d into demystifyfp:master May 23, 2021
TheAngryByrd added a commit that referenced this pull request May 23, 2021
@TheAngryByrd
Bump version to 2.4.0-beta001
ba9f9d2 
- Adds defaultError and zipError helpers Credits [@sep2](https://github.com/sep2) - (#130)
TheAngryByrd added a commit that referenced this pull request May 23, 2021
@TheAngryByrd
Bump version to 2.4.0
6bea86c 
- Adds defaultError and zipError helpers Credits [@sep2](https://github.com/sep2) - (#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sep2 @TheAngryByrd