Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option.maybe #189

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

gdziadkiewicz
Copy link
Contributor

@gdziadkiewicz gdziadkiewicz commented Oct 31, 2022

Fix #181

Proposed Changes

Add Option.maybe and tests for it.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@gdziadkiewicz gdziadkiewicz marked this pull request as ready for review October 31, 2022 16:50
Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! CI is failing for some nuget related reasons.

@TheAngryByrd TheAngryByrd merged commit 4ac6a5b into demystifyfp:master Oct 31, 2022
TheAngryByrd added a commit that referenced this pull request Oct 31, 2022
TheAngryByrd added a commit that referenced this pull request Oct 31, 2022
@gdziadkiewicz
Copy link
Contributor Author

@TheAngryByrd could you label the PR with HACKTOBERFEST-ACCEPTED label?

@gdziadkiewicz gdziadkiewicz deleted the Add_Option.maybe_#181 branch October 31, 2022 19:14
@TheAngryByrd TheAngryByrd mentioned this pull request Nov 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option.maybe
2 participants