Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to resumable while #202

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Fixes to resumable while #202

merged 1 commit into from
Dec 17, 2022

Conversation

TheAngryByrd
Copy link
Collaborator

@TheAngryByrd TheAngryByrd commented Dec 17, 2022

Proposed Changes

Fixes resumable while to return true when it's completed, rather than false and relying on the Resumable.While code to end the loop.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd merged commit 1fe1ab1 into master Dec 17, 2022
TheAngryByrd added a commit that referenced this pull request Dec 17, 2022
- [Fixes while implementation in resumable codes](#202) Credits @TheAngryByrd
- [Adds CancellableResultTask functions](#203) Credits @TheAngryByrd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant