Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncValidation #215

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Conversation

1eyewonder
Copy link
Contributor

@1eyewonder 1eyewonder commented Jun 20, 2023

Proposed Changes

Added AsyncValidation functionality per request of #209

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Majority of code was copied from Validation functions and converted to async. I'm sure there are plenty of things I'll need to address on the PR, but I wanted to get the code out there to start the conversation/reviews. I'm more than happy helping on documentation as well, I just figured I'd get a thumbs up on implementation first from the maintainers.

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Left some feedback on changes needed for this.

src/FsToolkit.ErrorHandling/AsyncValidationCE.fs Outdated Show resolved Hide resolved
src/FsToolkit.ErrorHandling/AsyncValidationCE.fs Outdated Show resolved Hide resolved
@1eyewonder
Copy link
Contributor Author

Done! Would the next steps be adding documentation in the gitbook folder?

@TheAngryByrd
Copy link
Collaborator

Yeah some documentation for that would be nice too :)

@TheAngryByrd TheAngryByrd merged commit 474897e into demystifyfp:master Jun 21, 2023
TheAngryByrd added a commit that referenced this pull request Jun 21, 2023
- [Added AsyncValidation](#215) Credits @1eyewonder
TheAngryByrd added a commit that referenced this pull request Jun 21, 2023
- [Added AsyncValidation](#215) Credits @1eyewonder
@1eyewonder 1eyewonder deleted the feature/asyncValidation branch July 7, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants