Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added traverse and sequence functions for Option #231

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

1eyewonder
Copy link
Contributor

Proposed Changes

Added traverse and sequence functions for both Option and AsyncOption types. I made this due to discussion in the discord channel and thought it may be pretty straight forward.

Functions added:

  • List.traverseOptionM
  • List.traverseAsyncOptionM
  • List.sequenceOptionM
  • List.sequenceAsyncOptionM

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If the behavior matches what is expected, let me know and I can create the documentation as well 😄

Do we think the applicative versions should be added as well? I didn't see an immediate use case but I know pblasucci in the discord was the one with the use case

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@TheAngryByrd TheAngryByrd merged commit a05ee9e into demystifyfp:master Oct 16, 2023
3 checks passed
TheAngryByrd added a commit that referenced this pull request Oct 16, 2023
- [Added traverse and sequence functions for Option](#231) Credits @1eyewonder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants