-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support voption to require function #243
Merged
TheAngryByrd
merged 8 commits into
demystifyfp:master
from
Maxumka:add_support_voption_to_require_function
Dec 10, 2023
Merged
Add support voption to require function #243
TheAngryByrd
merged 8 commits into
demystifyfp:master
from
Maxumka:add_support_voption_to_require_function
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
add_support_voption_to_require_function
branch
from
December 9, 2023 22:27
7323803
to
c32eda0
Compare
TheAngryByrd
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! And all the documentation is great :)
Note: I realized we weren't running tests in CI so I had to rebase your branch after I fixed it and force push.
TheAngryByrd
force-pushed
the
add_support_voption_to_require_function
branch
from
December 10, 2023 19:28
c3ec5d4
to
cf3fb78
Compare
TheAngryByrd
added a commit
that referenced
this pull request
Dec 10, 2023
TheAngryByrd
added a commit
that referenced
this pull request
Dec 10, 2023
TheAngryByrd
added a commit
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@TheAngryByrd Hi.
In my company we use voption and to convert to result we need to write our own functions for different projects. For convenience I would like to have them in a package at once
Types of changes
Checklist
Further comments
Also added bind functions to require voption