Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 0 edits #60

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Conversation

dankamongmen
Copy link
Contributor

I think you might want to provide example texts on architecture and operating systems. "Data-center" is written "data center". Your use of "well-known" is a postpositive and thus ought be written "well known". I converted a few comma splices to semicolons. Fixed a few number problems.

It would be great if I could break these long lines into shorter ones -- the edits will definitely be
easier to manage for you, I think.


This book will also be useful for any developer who wants to understand the performance of their application better and to know how it can be diagnosed and improved. You may just be enthusiastic about performance engineering and want to learn more about it. Or you may want to be the smartest engineer in the room, that's also fine. I hope that the material presented in this book will help you develop new skills that can be applied in your daily work and potentially move your career forward.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally considered bad form to start sentences with conjunctions. It's not a hard and fast rule, but one to be honored more often than it is broken. I'll continue remedying these unless you'd rather I not.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. Please go ahead.

@dankamongmen
Copy link
Contributor Author

@dendibakh , take a look at these edits and let me know if they're too invasive or otherwise undesirable. This is the level at which I currently intend to edit.

I think you might want to provide example texts on
architecture and operating systems. "Data-center" is
written "data center". Your use of "well-known" is
a postpositive and thus ought be written "well known".
I converted a few comma splices to semicolons. Fixed
a few number problems.

It would be great if I could break these long lines
into shorter ones -- the edits will definitely be
easier to manage for you, I think.

I joined Intel in 2017, but even before that I never shied away from software optimization tasks. I always got a dopamine hit when I saw the running time of my program went from 10 seconds down to 1 second. That feeling of excitement of discovering something, feeling proud of yourself. It made me even more curious and craving for more. I've been doing performance-related work a lot more chaotic back then. Now I do it more professionally, however, I still feel very happy when I make the software run faster. I wish you too experience the joy of discovering performance issues in your application and the satisfaction of fixing them.
I joined Intel in 2017, but even before that I never shied away from software optimization tasks. I always got a dopamine hit when I reduced the running time of my program from ten seconds to one second. The excitement of discovering something and feeling proud left me even more curious, always craving for more. My initial performance work was amateurish and undirected. Now it is my profession, yet I still feel very happy when I make software run faster. I hope you also experience the joy of discovering performance issues, and the satisfaction of fixing them.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's choose a different word instead of "amateurish". Otherwise, it could undermine the credibility of the main author. :)
I kinda knew something already at that time, but it was very unstructured. That's what I wanted to say.


[TODO]: put a link to an errata webpage
[TODO]: supply links to prerequisite material (H&P, Tanenbaum(?))
Copy link
Owner

@dendibakh dendibakh Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people will find these books on their own.
In the second edition, I decided to remove links and footnotes to easily google'able things from Wikipedia, etc.

@dendibakh
Copy link
Owner

@dendibakh , take a look at these edits and let me know if they're too invasive or otherwise undesirable. This is the level at which I currently intend to edit.

So far everything looks good. The level of edits seems reasonable to me.

Copy link
Contributor Author

@dankamongmen dankamongmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bah meant to submit these notes with the PR

@dendibakh dendibakh merged commit 05beea6 into dendibakh:main Sep 7, 2024
1 check passed
@dankamongmen dankamongmen deleted the dankamongmen/ch0-edits branch September 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants