Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql: de-couple the packet size from the buffer size #304

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

kardianos
Copy link
Collaborator

If the packet size is set too small, the read buffer size will
overflow. Prevent this by setting the buffer size independent of the
packet size.

For #166

If the packet size is set too small, the read buffer size will
overflow. Prevent this by setting the buffer size independent of the
packet size.

For #166
@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #304 into master will increase coverage by 0.09%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   66.77%   66.86%   +0.09%     
==========================================
  Files          22       22              
  Lines        4695     4690       -5     
==========================================
+ Hits         3135     3136       +1     
+ Misses       1348     1343       -5     
+ Partials      212      211       -1
Impacted Files Coverage Δ
tds.go 65.5% <100%> (ø) ⬆️
mssql.go 83.5% <100%> (+0.23%) ⬆️
buf.go 86.75% <96.96%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee80a5a...be9747b. Read the comment docs.

@kardianos kardianos merged commit 8855564 into master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant