Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing context to the tokenprovider func #597

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

serbrech
Copy link

@serbrech serbrech commented Sep 2, 2020

the tokenprovider func is chanigng in this PR:
#547

Seeing as it might possibly take some time to land the PR in master, I'd like to provide a simpler update to the tokenprovider func and pass it the context.

@serbrech serbrech changed the title passing context to the tokenprovider fun passing context to the tokenprovider func Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files          23       23           
  Lines        5190     5190           
=======================================
  Hits         3567     3567           
  Misses       1410     1410           
  Partials      213      213           
Impacted Files Coverage Δ
accesstokenconnector.go 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b6ff1...c3f8028. Read the comment docs.

@serbrech
Copy link
Author

serbrech commented Sep 28, 2020

Is there anyone reviewing PRs for this project?
Should we fork it? @denisenkom ? @kardianos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant