Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore spurious "rowcount" data from the server #735

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

shueybubbles
Copy link
Contributor

SQL sends rowcount status tokens in the done message for statements like declare @d int = 1. The driver needs to keep track of whether columns have been sent or if the statement is not a select statement to determine if a real "rows affected" message should be sent.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #735 (29bb0e8) into master (e538731) will decrease coverage by 0.06%.
The diff coverage is 69.81%.

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   71.29%   71.23%   -0.07%     
==========================================
  Files          24       24              
  Lines        5386     5416      +30     
==========================================
+ Hits         3840     3858      +18     
- Misses       1301     1312      +11     
- Partials      245      246       +1     
Impacted Files Coverage Δ
mssql.go 86.82% <53.57%> (-0.93%) ⬇️
token.go 64.87% <88.00%> (+0.66%) ⬆️
tds.go 65.49% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e538731...29bb0e8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant