create patch from .tar instead of .tar.gz (alternative solution) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifying individual patches inside the loop does tell us which specific patch failed, but in the end we still mark all patches as .failed, so we'd be doing unnecessary work.
It would be cleaner, and easier to test, if we separated the diff/patch and hash/verify steps. However, we need to verify right after patching, but *before* writing the dst file. Thus, the hash verification step was pulled inside the patch method. Now, for consistency, it makes sense to pull the hash creation into the diff method.
and update test data to match
dennisvang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified alternative to PR #93, with the same basic idea:
The original implementation creates patches from the diff between subsequent gzipped archives (
.tar.gz).This leads to excessive patch sizes, because small changes in the source can lead to large changes in the gzip-compressed archives. As a result, patches become practically useless.
The new solution adopted in this PR is to create patches from the uncompressed
.tarfiles. This leads to much smaller diffs, making patches useful again.Note that the archives are still compressed using gzip, in order to save bandwidth and storage space, but they are decompressed before patching, and re-compressed after patching.
One drawback is that patch creation, on the repo-side, now takes a lot longer, simply because an uncompressed archive is (much) larger than a compressed one. Also we are more likely to run into memory size limits, see e.g. 1, 2:
fixes #69