Always return dict for custom metadata #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always return a
dict
fromTargetMeta.custom
andcustom_internal
(instead optionaldict
).This breaks any code that explicitly relies on the possibility that custom metadata is
None
, for example:Code that simply checks for custom metadata, as in
if my_meta.custom: ...
, orif my_meta.custom is not None: ...
, is not affected.fixes #131