Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add purge_extract_dir option to Client #91

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

add purge_extract_dir option to Client #91

wants to merge 26 commits into from

Conversation

dennisvang
Copy link
Owner

This uses a purge.manifest file to prevent accidental deletion of unrelated files...

Note: Perhaps this is too complicated? Should we simply rely on a namespaced extract_dir?

fixes #56

@dennisvang
Copy link
Owner Author

dennisvang commented Nov 10, 2023 •
edited
Loading

Again with the aliases on windows:

C:\Users\runneradmin\... vs C:\Users\RUNNER~1\...

and on macOS:

/private/var/folders/3s/... vs /var/folders/3s/...

Path.resolve() to the rescue.

See #78 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

force clean-up of temporary extract dir
1 participant
@dennisvang