Skip to content

Commit

Permalink
chore: add internal webidl helpers for enums and nullables (#9504)
Browse files Browse the repository at this point in the history
Co-authored-by: Luca Casonato <[email protected]>
  • Loading branch information
Anonymous and lucacasonato authored Feb 15, 2021
1 parent 0cf952e commit a6beab8
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 3 deletions.
36 changes: 35 additions & 1 deletion op_crates/web/00_webidl.js
Original file line number Diff line number Diff line change
Expand Up @@ -662,10 +662,44 @@
};
}

window.__bootstrap = window.__bootstrap || {};
// https://heycam.github.io/webidl/#es-enumeration
function createEnumConverter(name, values) {
const E = new Set(values);

return function (V, opts = {}) {
const S = String(V);

if (!E.has(S)) {
throw makeException(
TypeError,
`The provided value '${V}' is not a valid enum value of type ${name}.`,
opts,
);
}

return S;
};
}

function createNullableConverter(converter) {
return (V, opts = {}) => {
// FIXME: If Type(V) is not Object, and the conversion to an IDL value is
// being performed due to V being assigned to an attribute whose type is a
// nullable callback function that is annotated with
// [LegacyTreatNonObjectAsNull], then return the IDL nullable type T?
// value null.

if (V === null || V === undefined) return null;
return converter(V, opts);
};
}

window.__bootstrap ??= {};
window.__bootstrap.webidl = {
converters,
requiredArguments,
createDictionaryConverter,
createEnumConverter,
createNullableConverter,
};
})(this);
19 changes: 17 additions & 2 deletions op_crates/web/internal.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,13 +209,28 @@ declare namespace globalThis {
required?: boolean;
}

/**ie
* Assert that the a function has at least a required amount of arguments.
/**
* Create a converter for dictionaries.
*/
declare function createDictionaryConverter<T>(
name: string,
...dictionaries: Dictionary[]
): (v: any, opts: ValueConverterOpts) => T;

/**
* Create a converter for enums.
*/
declare function createEnumConverter(
name: string,
values: string[],
): (v: any, opts: ValueConverterOpts) => string;

/**
* Create a converter that makes the contained type nullable.
*/
declare function createNullableConverter<T>(
converter: (v: any, opts: ValueConverterOpts) => T,
): (v: any, opts: ValueConverterOpts) => T | null;
}

declare var url: {
Expand Down

0 comments on commit a6beab8

Please sign in to comment.