Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't report diagnostics for "external" TypeScript code #11970

Closed
kitsonk opened this issue Sep 10, 2021 · 1 comment · Fixed by #12766
Closed

Don't report diagnostics for "external" TypeScript code #11970

kitsonk opened this issue Sep 10, 2021 · 1 comment · Fixed by #12766
Assignees
@kitsonk @lucacasonato
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Sep 10, 2021

When type checking a project, by default don't report type diagnostics for "external" files. (raised as 2.0 scope by @lucacasonato)

Things we need to do to make this proposal more viable would be:

  • Define what "external" files are. Are they any modules outside the cwd/root of a project? Are they only remote modules?
  • How would this integrate well with Skip type checking by default #11340 without adding a lot of complexity?
@kitsonk kitsonk added suggestion suggestions for new features (yet to be agreed) maybe 2.0 labels Sep 10, 2021
@kitsonk kitsonk mentioned this issue Sep 17, 2021
Closed
17 tasks
@kitsonk kitsonk added this to the 2.0.0 milestone Sep 17, 2021
@wojpawlik
Copy link

wojpawlik commented Sep 19, 2021 •
edited
Loading

If reporting diagnostics only for local TypeScript files would speed up start-up, it'd be an interesting alternative to #11340.
Also, I'd have prevented colinhacks/zod#648.

@lucacasonato lucacasonato mentioned this issue Nov 3, 2021
Merged
@nayeemrmn nayeemrmn mentioned this issue Nov 10, 2021
Closed
@kitsonk kitsonk self-assigned this Nov 15, 2021
@kitsonk kitsonk removed this from the 2.0.0 milestone Nov 15, 2021
kitsonk added a commit to kitsonk/deno that referenced this issue Nov 15, 2021
@kitsonk
feat: add --no-check=remote flag
38e6f91 
Closes denoland#11970
@kitsonk kitsonk mentioned this issue Nov 15, 2021
Merged
kitsonk added a commit to kitsonk/deno that referenced this issue Nov 28, 2021
@kitsonk
feat: add --no-check=remote flag
f2d1fde 
Closes denoland#11970
kitsonk added a commit that referenced this issue Nov 29, 2021
@kitsonk
feat: add --no-check=remote flag (#12766)
18a63dd 
Closes #11970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

@lucacasonato lucacasonato

Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --no-check=remote flag kitsonk/deno
3 participants
@kitsonk @lucacasonato @wojpawlik