Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: support per workspace folder deno.jsonc #14245

Closed
kitsonk opened this issue Apr 9, 2022 · 2 comments
Closed

lsp: support per workspace folder deno.jsonc #14245

kitsonk opened this issue Apr 9, 2022 · 2 comments
Assignees
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Apr 9, 2022

There are several scenarios where being able to have one workspace in the editor, but a different deno.jsonc apply is becoming increasingly necessary. When combining front-end and back end code as part of the same project for example.

The challenge is a couple fold, mostly with resolving config files on a workspace folder perspective and managing those config files depending on what specifier is being queried. In addition the TS language server has the plumbing for type checking on a "project" basis, but our communication with it does not currently account for that, which means we would need to re-plumb that.

It us a non-trivial piece of work but I have ideas on an approach.

Ref: denoland/vscode_deno#787

@kitsonk kitsonk added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Apr 9, 2022
@kitsonk kitsonk self-assigned this Apr 9, 2022
@swandir
Copy link

swandir commented Apr 10, 2022

Would it support config auto-discovery?

And could it be made to work without needing an explicit multi-root workspace? From the user's perspective it'd be awesome to just open a directory and see that everything works with no additional config.

@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 25, 2022

I'm not totally sure at this point. We have to figure out a few things first, like how to juggle it. It maybe something that gets delivered incrementally, enhancing as we go along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Development

No branches or pull requests

3 participants