Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: config auto-detection not reliable #15386

Closed
kitsonk opened this issue Aug 2, 2022 · 1 comment
Closed

lsp: config auto-detection not reliable #15386

kitsonk opened this issue Aug 2, 2022 · 1 comment
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Aug 2, 2022

In certain scenarios when using multi-root workspaces in vscode a Deno configuration file is not being auto detected (see: denoland/fresh#514).

We should better determine which root to auto detect a configuration file, by enumerating the workspace folders checking their enablement and seeing if there is a config file, until one is found.

We might also want to consider logging out the path searched for a configuration files, wether we find them or not, as we currently only log when we find one, making it difficult to identify why somethings isn't working.

Ref #14455 - re-working workspace folders

@kitsonk kitsonk added bug Something isn't working correctly lsp related to the language server labels Aug 2, 2022
@nayeemrmn
Copy link
Collaborator

Currently it's by design that we only look at the first workspace folder, auto-detection in other places only makes sense coupled with multi-config monorepo support. Tracked by denoland/vscode_deno#787 and #14245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

No branches or pull requests

2 participants