Parcel Bundler Error - fs.findAncestorFile #16460

rawkakani · 2022-10-28T08:46:33Z

Hi
I am currently running into an issue where I am following the Parcel API documentation, and currently running into a Type error as below

error: Uncaught TypeError: fs.findAncestorFile is not a function

Currently using Deno 1.27.0, I would like to find out if there is another way to use parcel with Deno ?

I am importing @parcel/core and not parcel

System
Apple M1
macOS Ventura

The text was updated successfully, but these errors were encountered:

rawkakani · 2022-10-28T10:48:29Z

I got as far as napi_add_finalizer is not yet supported. could I please be guided in where this would be implemented, or a PR where it is currently in progress

bartlomieju · 2022-10-28T11:30:22Z

I've opened an issue in deno_std to add the missing API.

rawkakani · 2022-10-28T11:32:10Z

I've opened an issue in deno_std to add the missing API.

awesome thank you so much

Seally · 2022-10-28T12:54:01Z

This function seems to be defined in Parcel (probably this one: https://github.com/parcel-bundler/parcel/blob/27bf5963322ba124b4878a0e4cfd6d60979b0d02/packages/core/fs/src/find.js#L35) and not in Node. I did a text search in the Node codebase and Node docs and couldn't find any results for findAncestorFile.

I haven't investigated why it's not on the fs object in this case, however. Since it seems Parcel has several different implementations of fs involved, I'm not sure which fs the code is referring to. Are you using Node/Deno's fs and not Parcel's variants?

Edit: There's a native implementation for the function with napi as well, but I'm not well-versed enough to know if it's relevant.

BoltDoggy · 2022-11-04T06:43:54Z

https://github.com/parcel-bundler/parcel/blob/411d4c2e81f2dd9aa25be4fab82623e39f9ca49a/packages/core/fs/src/NodeFS.js#L50

这里的 searchNative 即 @parcel/fs-search 只有

{
  writeSnapshot: [Function],
  getEventsSince: [Function],
  subscribe: [Function],
  unsubscribe: [Function]
}

也许是在 deno 环境下加载 node 插件异常

rawkakani · 2022-11-12T13:03:45Z

awesome thank you for the feedback attemped to implement a custom fs.findAncestorFile using @BoltDoggy comment and got a new error Error: Not implemented: v8.setFlagsFromString

can someone guide me to what this is, or is there a way for me to inplement this manually

@bartlomieju how can I start contributing to Deno

lilnasy · 2022-11-17T15:34:54Z

Are you using parcel-bundler, which is deprecated?

rawkakani · 2022-11-18T20:18:17Z

Are you using parcel-bundler, which is deprecated?

oh no I am using @parcel/core

rawkakani · 2022-11-18T20:19:30Z

Are you using parcel-bundler, which is deprecated?

@lilnasy does the npm:parcel work now for you?

lilnasy · 2022-11-19T12:06:38Z

I ran the canary build and sadly, it does not work. It does not panic anymore, but now I get the same error as you: fs.findAncestorFile is not a function.

On a different note, it's interesting that it says that specifically, not that it's undefined.

lilnasy · 2022-11-19T12:22:32Z

I added console.log's to deno's cached files and turns out fs.findAncestorFile really is undefined, ~~along with the rest of parcel's custom fs, which gets shared around as a function parameter~~ (ran the cli before vscode could save the file).

I couldn't find anything more because deno wouldn't wait for me attach a debugger before it throws this error.

@rawkakani are you able to attach a debugger with the --inspect-brk flag.

lilnasy · 2022-11-19T12:57:51Z

The issue seems to be with the experimental Node API support. @parcel/fs re-exports a few functions from @parcel/fs-search which is an NAPI library. At least 3 of the functions that @parcel/fs expects from require("@parcel/fs-search") are missing, including findAncestorFile.

bartlomieju · 2022-11-20T09:49:28Z

@littledivy please take a look

rawkakani · 2022-11-22T19:52:54Z

The issue seems to be with the experimental Node API support. @parcel/fs re-exports a few functions from @parcel/fs-search which is an NAPI library. At least 3 of the functions that @parcel/fs expects from require("@parcel/fs-search") are missing, including findAncestorFile.

@lilnasy I extended the deno fs like this

import * as searchNative from 'npm:@parcel/fs-search';
// import defaultConfig from 'npm:@parcel/config-default' 
let inputFS = Deno;
inputFS.findAncestorFile = searchNative.default.findAncestorFile

and changed the FS that parcel core uses

let bundler = new Parcel({
  entries: 'a.js',
  defaultConfig: '@parcel/config-default',
  inputFS
});

and got the error above I mentioned

I will attempt to attach the debugger

lilnasy · 2022-11-22T21:02:25Z

@rawkakani That specific error has to do with Node's V8 API. V8 is what Node and Deno use under the hood to run javascript, and for now Deno does not have a compatibility layer to directly interact with it. v8.setFlagsFromString makes changes to V8, you can't manually implement it from within javascript land.

The fact that you are directly able to import findAncestorFile from @parcel/fs-search is interesting though, because @parcel/fs could not. I fiddled around a bit more and it turns out Deno imports different functions from @parcel/fs-search depending on how/where it is imported.

Via another npm package

Directly via an npm specifier

marvinhagemeister · 2023-05-24T22:10:24Z

I think I found a clue. Was logging all exports when a native addon is loaded and noticed that @parcel/watcher/prebuilds/darwin-arm64/node.napi.glibc.node is loaded just before the one that has wrong exports. The load order is:

@parcel/source-map/parcel_sourcemap_node/artifacts/index.darwin-arm64.node - Correct
@parcel/hash/parcel-hash.darwin-arm64.node - Correct
@parcel/watcher/prebuilds/darwin-arm64/node.napi.glibc.node - Correct
@parcel/fs-search/fs-search.darwin-arm64.node - WRONG, returns exports from node.napi.glibc.node

Screenshot of the exports:

Logging out the v8 pointer confirms that both node.napi.glibc.node and fs-search.darwin-arm64.node share the same address. Somehow it seems that deno returns the same pointer for two different modules. Comparing the exports and the packages confirms that the returned API belongs to @parcel/watcher and not @parcel/fs-search.

bartlomieju · 2023-05-24T22:44:49Z

Nice investigation @marvinhagemeister. Can you share the code where you dump the pointers?

marvinhagemeister · 2023-05-25T06:38:57Z

@bartlomieju Upon second look I think I got the pointer bit wrong. Printed out the exports NapiValue inside the match statement of op_napi_open on this line. But I now realize that it's the same for all of them. Maybe I was too tired yesterday evening (or it's way over my head as a frontend dev :P ).

Either way, as far as I can tell the modules which run into the bug described here go through the Some(nm) case of the surrounding match expression. The ones falling through None seem fine. That's as far as I can debug it though. My knowledge on native stuff is too limited.

deno/ext/napi/lib.rs

Lines 628 to 656 in 935071d

    
           Some(nm) => { 
        
             // SAFETY: napi_register_module guarantees that `nm` is valid. 
        
             let nm = unsafe { &*nm }; 
        
             assert_eq!(nm.nm_version, 1); 
        
             // SAFETY: we are going blind, calling the register function on the other side. 
        
             let maybe_exports = unsafe { 
        
               (nm.nm_register_func)( 
        
                 env_ptr, 
        
                 std::mem::transmute::<v8::Local<v8::Value>, napi_value>( 
        
                   exports.into(), 
        
                 ), 
        
               ) 
        
             }; 
        
             let exports = maybe_exports 
        
               .as_ref() 
        
               .map(|_| unsafe { 
        
                 // SAFETY: v8::Local is a pointer to a value and napi_value is also a pointer 
        
                 // to a value, they have the same layout 
        
                 std::mem::transmute::<napi_value, v8::Local<v8::Value>>( 
        
                   maybe_exports, 
        
                 ) 
        
               }) 
        
               .unwrap_or_else(|| { 
        
                 // If the module didn't return anything, we use the exports object. 
        
                 exports.into() 
        
               }); 
        
             Ok(serde_v8::Value { v8_value: exports })

Made an isolated reproduction case.

Steps to reproduce

Clone https://github.com/marvinhagemeister/deno-parcel-bug
Run deno task dev

bartlomieju · 2023-05-25T08:20:11Z

Thanks @marvinhagemeister! I just spotted the error here, will fix it at first convenience.

This commit fixes problem with loading N-API modules that use the "old" way of registration (using "napi_module_register" API). The slot was not cleared after loading modules, causing subsequent calls that use the new way of registration (using "napi_register_module_v1" API) to try and load the previous module. Ref #16460 --------- Co-authored-by: Divy Srivastava <[email protected]>

Towards #16460

rawkakani · 2023-05-27T22:36:14Z

are these changes available in 1.34?

bartlomieju · 2023-05-28T18:37:55Z

@rawkakani, no, they will be available in v1.34.1 to be release later this week.

rawkakani · 2023-05-28T19:24:29Z

@rawkakani, no, they will be available in v1.34.1 to be release later this week.

@bartlomieju thank you

rawkakani · 2023-05-30T10:53:53Z

I have upgraded to 1.34.1, and have gotten the below error trying to implement Parcel API

error: Uncaught (in worker "$DENO_STD_NODE_WORKER_THREAD") TypeError: Cannot read properties of undefined (reading 'startsWith')
    at Array.get (ext:deno_node/process.ts:486:33)
    at Array.indexOf (<anonymous>)
    at module.exports (file:///Users/rawkakani/Documents/rnd/node_modules/.deno/[email protected]/node_modules/has-flag/index.js:5:24)
    at Object.<anonymous> (file:///Users/rawkakani/Documents/rnd/node_modules/.deno/[email protected]/node_modules/supports-color/index.js:9:5)
    at Object.<anonymous> (file:///Users/rawkakani/Documents/rnd/node_modules/.deno/[email protected]/node_modules/supports-color/index.js:137:4)
    at Module._compile (ext:deno_node/01_require.js:974:34)
    at Object.Module._extensions..js (ext:deno_node/01_require.js:1007:10)
    at Module.load (ext:deno_node/01_require.js:885:32)
    at Function.Module._load (ext:deno_node/01_require.js:719:12

this occurs when I use the below script and install @parcel/config-default locally using npm

import {Parcel} from 'npm:@parcel/core';

let bundler = new Parcel({
    entries: './a.js',
    defaultConfig: '@parcel/config-default'
});

if anyone does get this right can you please let me know

however the fs.findAncestorFile error is gone thank you @bartlomieju

bartlomieju · 2023-05-30T11:17:53Z

I believe the error you are seeing is the same problem as #18334 is trying to fix.

rawkakani · 2023-05-30T11:21:54Z

I believe the error you are seeing is the same problem as #18334 is trying to fix.

okay awesome thank you, is it cool to close this issue and watch the PR you mentioned

rawkakani changed the title ~~Parcel Bundler Error, ( fs.findAncestorFile)~~ Parcel Bundler Error - fs.findAncestorFile Oct 28, 2022

bartlomieju mentioned this issue Oct 28, 2022

node: fs.findAncestorFile is not supported denoland/std#2821

Closed

dsherret added bug Something isn't working correctly node compat needs investigation requires further investigation before determining if it is an issue or not and removed bug Something isn't working correctly labels Oct 31, 2022

lilnasy mentioned this issue Nov 17, 2022

Panic npm:parcel #16683

Closed

bartlomieju added the node native extension related to the node-api (.node) label Nov 20, 2022

bartlomieju assigned littledivy Nov 20, 2022

lilnasy mentioned this issue Nov 22, 2022

--inspect-brk doesn't stop execution when running global npm commands #16757

Closed

lilnasy mentioned this issue Dec 17, 2022

npm compat: module imported via .node file is missing exports #17085

Closed

bartlomieju mentioned this issue Jan 17, 2023

npm: node-rfc LoadLibraryExW failed #17411

Open

bartlomieju mentioned this issue May 25, 2023

fix(napi): clear currently registering module slot #19249

Merged

bartlomieju mentioned this issue May 26, 2023

fix(node): make 'v8.setFlagsFromString' a noop #19271

Merged

bartlomieju added a commit that referenced this issue May 26, 2023

fix(node): make 'v8.setFlagsFromString' a noop (#19271)

160fe97

Towards #16460

mischnic mentioned this issue May 29, 2023

Support deno parcel-bundler/parcel#7108

Open

rawkakani closed this as completed Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parcel Bundler Error - fs.findAncestorFile #16460

Parcel Bundler Error - fs.findAncestorFile #16460

rawkakani commented Oct 28, 2022 •

edited

Loading

rawkakani commented Oct 28, 2022

bartlomieju commented Oct 28, 2022

rawkakani commented Oct 28, 2022

Seally commented Oct 28, 2022 •

edited

Loading

BoltDoggy commented Nov 4, 2022 •

edited

Loading

rawkakani commented Nov 12, 2022 •

edited

Loading

lilnasy commented Nov 17, 2022

rawkakani commented Nov 18, 2022

rawkakani commented Nov 18, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

bartlomieju commented Nov 20, 2022

rawkakani commented Nov 22, 2022

lilnasy commented Nov 22, 2022

marvinhagemeister commented May 24, 2023

bartlomieju commented May 24, 2023

marvinhagemeister commented May 25, 2023 •

edited

Loading

bartlomieju commented May 25, 2023

rawkakani commented May 27, 2023

bartlomieju commented May 28, 2023

rawkakani commented May 28, 2023

rawkakani commented May 30, 2023 •

edited

Loading

bartlomieju commented May 30, 2023

rawkakani commented May 30, 2023 •

edited

Loading

Parcel Bundler Error - fs.findAncestorFile #16460

Parcel Bundler Error - fs.findAncestorFile #16460

Comments

rawkakani commented Oct 28, 2022 • edited Loading

rawkakani commented Oct 28, 2022

bartlomieju commented Oct 28, 2022

rawkakani commented Oct 28, 2022

Seally commented Oct 28, 2022 • edited Loading

BoltDoggy commented Nov 4, 2022 • edited Loading

rawkakani commented Nov 12, 2022 • edited Loading

lilnasy commented Nov 17, 2022

rawkakani commented Nov 18, 2022

rawkakani commented Nov 18, 2022 • edited Loading

lilnasy commented Nov 19, 2022 • edited Loading

lilnasy commented Nov 19, 2022 • edited Loading

lilnasy commented Nov 19, 2022 • edited Loading

bartlomieju commented Nov 20, 2022

rawkakani commented Nov 22, 2022

lilnasy commented Nov 22, 2022

marvinhagemeister commented May 24, 2023

bartlomieju commented May 24, 2023

marvinhagemeister commented May 25, 2023 • edited Loading

Steps to reproduce

bartlomieju commented May 25, 2023

rawkakani commented May 27, 2023

bartlomieju commented May 28, 2023

rawkakani commented May 28, 2023

rawkakani commented May 30, 2023 • edited Loading

bartlomieju commented May 30, 2023

rawkakani commented May 30, 2023 • edited Loading

rawkakani commented Oct 28, 2022 •

edited

Loading

Seally commented Oct 28, 2022 •

edited

Loading

BoltDoggy commented Nov 4, 2022 •

edited

Loading

rawkakani commented Nov 12, 2022 •

edited

Loading

rawkakani commented Nov 18, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

lilnasy commented Nov 19, 2022 •

edited

Loading

marvinhagemeister commented May 25, 2023 •

edited

Loading

rawkakani commented May 30, 2023 •

edited

Loading

rawkakani commented May 30, 2023 •

edited

Loading