Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bundles always use TLA, though browsers don't support TLA #4123

Closed
kitsonk opened this issue Feb 25, 2020 · 0 comments · Fixed by #4124
Closed

feat: bundles always use TLA, though browsers don't support TLA #4123

kitsonk opened this issue Feb 25, 2020 · 0 comments · Fixed by #4124

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Feb 25, 2020

As point out in #4031 (comment) the changes to the bundles to support TLA in TypeScript 3.8 also forced all bundles to require support of TLA, even if none of the modules in the bundle required TLA. We should fix this since browser support for TLA seems a way off.
kitsonk added a commit to kitsonk/deno that referenced this issue Feb 25, 2020
@kitsonk
Bundles can be sync or async based on top level await
d2dab38 
Previously, bundles always utilised top level await, even if the bundled
modules didn't require top level await.  Now, analysis of the bundle is
done and if none of the bundled modules are asynchronously executed,
then the bundle as a whole will be synchronously executed.

Fixes denoland#4055
Fixes denoland#4123
@kitsonk kitsonk mentioned this issue Feb 25, 2020
Merged
kitsonk added a commit to kitsonk/deno that referenced this issue Feb 26, 2020
@kitsonk
Bundles can be sync or async based on top level await
9d9c7b8 
Previously, bundles always utilised top level await, even if the bundled
modules didn't require top level await.  Now, analysis of the bundle is
done and if none of the bundled modules are asynchronously executed,
then the bundle as a whole will be synchronously executed.

Fixes denoland#4055
Fixes denoland#4123
bartlomieju pushed a commit that referenced this issue Feb 26, 2020
@kitsonk
Bundles can be sync or async based on top level await (#4124)
671f0b8 
Previously, bundles always utilised top level await, even if the bundled
modules didn't require top level await.  Now, analysis of the bundle is
done and if none of the bundled modules are asynchronously executed,
then the bundle as a whole will be synchronously executed.

Fixes #4055
Fixes #4123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundles can be sync or async based on top level await kitsonk/deno
1 participant
@kitsonk